Thread: [dcplusplus-devel] patch: Filter already shared files in search

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

Hi,

I created a patch which will filter files from the search results, if they are
already in your own share (with same TTH).
It works well for me and I think others might like it, too.

Bye,
Smir
On 1/24/08, dcp...@sm... <dcp...@sm...> wrote:

> I created a patch which will filter files from the search results, if they are
> already in your own share (with same TTH).
> It works well for me and I think others might like it, too.

This should definitely be made an option.  I often search for
alternates on files in my own share to see how many other people have
the file---to see if I can safely delete it.

Hi,

Sorry for taking a while...I'd like to see this option too, but optional...so could you please add a
boolean setting for it?

Regards
/Jacek

dcp...@sm... wrote:
> Hi,
> 
> I created a patch which will filter files from the search results, if they are
> already in your own share (with same TTH).
> It works well for me and I think others might like it, too.
> 
> Bye,
> Smir

> Hi,
> 
> Sorry for taking a while...I'd like to see this option too, but optional...so
> could you please add a
> boolean setting for it?
> 
> Regards
> /Jacek
> 
> dcp...@sm... wrote:
> > Hi,
> > 
> > I created a patch which will filter files from the search results, if they
> are
> > already in your own share (with same TTH).
> > It works well for me and I think others might like it, too.
> > 
> > Bye,
> > Smir
> 

Now it is available as option in the Search Frame.

I created the patch file with "bzr send -o filtershared.patch", but I am not
sure if it can be used, because it is somehow encrypted :P
That's why I also send the diff.

I also have a question: How do I get a smaller filesize when compiling?
I use "scons mode=release" and always have an executable which is about 100 MB.
But the official release is only ~2MB...

Bye,
Smir
On Mon, Mar 24, 2008 at 1:08 PM, Smir <dcp...@sm...> wrote:

> I also have a question: How do I get a smaller filesize when compiling?
> I use "scons mode=release" and always have an executable which is about
> 100 MB.
> But the official release is only ~2MB...
>
> Bye,
> Smir
>

Use 'strip'.

-- 
Fredrik Ullner

Hi,

Thanks for the patch, but there are a few errors. First off, it seems that the bzr patch you sent is 
empty - I think you need to commit your changes locally (which is the default if you used "bzr 
branch") before doing "bzr send" - it gives the diff between the branch source and your commit, not 
what you have in your working tree. bzr diff will produce a diff against the working tree, but it 
won't include information about which revision you started from so a "bzr send" is preferable - I'm 
not very good with bzr though so I'm not sure - any form will be fine.

Second, you didn't add the setting to the strings in settingsmanager.cpp so it won't actually be 
loaded/saved.

Third you can use a reference here: "TTHValue t = aResult->getTTH();"  becomse "const TTHValue& t = 
aResult->getTTH();"...

Regards,
/J

Smir wrote:
>> Hi,
>>
>> Sorry for taking a while...I'd like to see this option too, but optional...so
>> could you please add a
>> boolean setting for it?
>>
>> Regards
>> /Jacek
>>
>> dcp...@sm... wrote:
>>> Hi,
>>>
>>> I created a patch which will filter files from the search results, if they
>> are
>>> already in your own share (with same TTH).
>>> It works well for me and I think others might like it, too.
>>>
>>> Bye,
>>> Smir
> 
> 
> Now it is available as option in the Search Frame.
> 
> I created the patch file with "bzr send -o filtershared.patch", but I am not
> sure if it can be used, because it is somehow encrypted :P
> That's why I also send the diff.
> 
> I also have a question: How do I get a smaller filesize when compiling?
> I use "scons mode=release" and always have an executable which is about 100 MB.
> But the official release is only ~2MB...
> 
> Bye,
> Smir
> 
> 
> ------------------------------------------------------------------------
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Microsoft
> Defy all challenges. Microsoft(R) Visual Studio 2008.
> http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> dcplusplus-devel mailing list
> dcp...@li...
> https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel

Hi,

ok, I fixed the patch. It was the first time for me working with bazar, but now
the patch looks fine :)
I also fixed those other two issues.

Bye,
Smir

> Hi,
> 
> Thanks for the patch, but there are a few errors. First off, it seems that
> the bzr patch you sent is 
> empty - I think you need to commit your changes locally (which is the default
> if you used "bzr 
> branch") before doing "bzr send" - it gives the diff between the branch
> source and your commit, not 
> what you have in your working tree. bzr diff will produce a diff against the
> working tree, but it 
> won't include information about which revision you started from so a "bzr
> send" is preferable - I'm 
> not very good with bzr though so I'm not sure - any form will be fine.
> 
> Second, you didn't add the setting to the strings in settingsmanager.cpp so
> it won't actually be 
> loaded/saved.
> 
> Third you can use a reference here: "TTHValue t = aResult->getTTH();" 
> becomse "const TTHValue& t = 
> aResult->getTTH();"...
> 
> Regards,
> /J
Ok, I think it worked this time - seems to have applied nicely =) Another similar option would be 
not to view things already in download queue...

/J

Smir wrote:
> Hi,
> 
> ok, I fixed the patch. It was the first time for me working with bazar, but now
> the patch looks fine :)
> I also fixed those other two issues.
> 
> Bye,
> Smir
> 

Thread: [dcplusplus-devel] patch: Filter already shared files in search

A Windows client for the Direct Connect networks

dcplusplus-devel