dcplusplus-devel

[dcplusplus-devel] passive users sometimes considered active in ADC

[poy <po...@12...>]

when an ADC hub sends the IP of a passive user, DC++ considers that user 
active, eventhough that user hasn't set TCP4 / UDP4 in the SU field of INF.
attached patch fixes it.

poy 

Re: [dcplusplus-devel] passive users sometimes considered active in ADC

[Jacek S. <arn...@gm...>]

looks reasonable - adch++ looks for u4/i4 (the port) - maybe that should be checked for too since
it's needed to actually do the connect...

/J

On 2009-12-11 18:07, poy wrote:
> when an ADC hub sends the IP of a passive user, DC++ considers that user
> active, eventhough that user hasn't set TCP4 / UDP4 in the SU field of INF.
> attached patch fixes it.
> 
> poy
> 
> 
> 
> ------------------------------------------------------------------------------
> Return on Information:
> Google Enterprise Search pays you back
> Get the facts.
> http://p.sf.net/sfu/google-dev2dev
> 
> 
> 
> _______________________________________________
> dcplusplus-devel mailing list
> dcp...@li...
> https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel

Re: [dcplusplus-devel] passive users sometimes considered active in ADC

[poy <po...@12...>]

> looks reasonable - adch++ looks for u4/i4 (the port) - maybe that should 
> be checked for too since
> it's needed to actually do the connect...

U4 (UDP port) is already being checked for, but the TCP port can't be 
checked in advance since it's not send via INF, but later in each CTM.

now the follow up, can i change ADCH++ to send IPs of every user, not just 
active ones? attached patch would do that.
it would allow some clients to process these IPs automatically and display 
them next to the nick for example. note that security is not a concern here 
since it's already possible to get these IPs with the +info command.

poy