Looks reasonable, fewer options = good.
Some comments:
1) WindowManager (singular)
2) It probably doesn't need locking (since all relevant calls are made from
the gui thread)
3) I assume viewOrder is not the ctrl-tab order but the order in which the
window tabs appear? (Don't remember =)
4) I'm not convinced about typeid - I wonder how stable that is across
compiler versions for example - also an msvc build would not use the same as
a gcc build...
5) Do we want search frames to auto-open?
/J
On Fri, Feb 13, 2009 at 7:00 PM, poy <po...@12...> wrote:
> attached patch adds a "Windows" tag in DCPlusPlus.xml where opened child
> views are saved before the program exits; when it starts again, all of the
> windows are restored back.
>
> since our windows have no id, i used typeid instead.
>
> hubs are handled slightly differently than other windows, since their
> address has to be saved, too. i also save the name of the hub although it is
> not used now, so that building a "recent hubs" menu should be easy from
> there.
>
> PMs and search windows are currently ignored; eventually, they should be
> handled the same as hubs.
>
> after this is in, the "auto-open on startup" options and "auto-connect"
> check-boxes in favorite hubs will have to be removed; i haven't cleaned them
> up in the patch.
>
> poy
|
