dcplusplus-devel

[dcplusplus-devel] Some more translations

[Michael J. <mrm...@ho...>]

Attached are some more translations.
Doing these / checking i noticed a few more things i thought i should bring=
 up to make others aware off.

In HubFrame the column uses "Nick" for "User name".  All the other frames u=
se "User".  Not really to sure about this one, because it works "as is" jus=
t thought i should mention it.

In PublicHubsFrame.cpp, the TSTRING(HUBNAME) goes to "Name".  Should this s=
tay as Name, or become Hub Name ?

Trying to convert the columns in HubFrame.cpp an error came on this line, w=
hich i wasn't sure how to fix correctly, so i reverted my changes until a s=
olution comes up (i have got a backup of it though). (Line 120 in svn694).
filterType->addValue(TSTRING_I(columnNames[j]));

In FinishedFrameBase.h TSTRING(REMOVE) translates to "&Remove" but all othe=
rs in that area don't have the ampersand, so should that one or not ? I wou=
ld think not, as "&Remove" is used on buttons and i think it's just been re=
used, and over looked.  So i left this one unchanged.

In FavHubProperties.cpp the string "Hub address cannot be empty." has a ful=
lstop at the end, as you can see.  But since no other strings have this, sh=
ould it be dropped for consistency, or left, with the intention of more mis=
sing fullstops being added to other strings in the future ?

I also noticed weird behaviour in ADLSearch
When change a entry from File to Directory, it wipes the Min Size, but not =
the Max Size.
When change a entry from File to Full path, it leaves both Min Size and Max=
 Size.
So what is the right behaviour, wiping Min Size in both places, but leaving=
 Max Size.  Wiping both Min Size and Max Size.  Or leaving both ?

And one quick last question for further translations.
TSTRING(BLAH) goes to T_("Blah")
How should CTSTRING(BLAH) end up ?

thanks MikeJJ

_________________________________________________________________
Free games, great prizes - get gaming at Gamesbox.=20
http://www.searchgamesbox.com=

Re: [dcplusplus-devel] Some more translations

[David G. <c0...@cs...>]

You've been busy :)

Michael Jones skrev:
> In PublicHubsFrame.cpp, the TSTRING(HUBNAME) goes to "Name".  Should this stay as Name, or become Hub Name ?
>   
I say stick with Name. The context makes it clear.
> Trying to convert the columns in HubFrame.cpp an error came on this line, which i wasn't sure how to fix correctly, so i reverted my changes until a solution comes up (i have got a backup of it though). (Line 120 in svn694).
> filterType->addValue(TSTRING_I(columnNames[j]));
>   
TSTRING_I(actual code) is a macro that doesn't take a 
ResourceManager::EnumValue...

Looking at the code, this would probably translate to T_(columnNames[j])
> In FinishedFrameBase.h TSTRING(REMOVE) translates to "&Remove" but all others in that area don't have the ampersand, so should that one or not ? I would think not, as "&Remove" is used on buttons and i think it's just been reused, and over looked.  So i left this one unchanged.
>   
In case you didn't know, the ampersand causes mnemonics to appear under 
characters, and keyboard accelerators to be activated. On later Windows 
versions they are hidden by default on buttons, can be shown by pressing 
the ALT key.

My guess is that all the items on the popup menu are all supposed to 
have mnemonics.

> In FavHubProperties.cpp the string "Hub address cannot be empty." has a fullstop at the end, as you can see.  But since no other strings have this, should it be dropped for consistency, or left, with the intention of more missing fullstops being added to other strings in the future ?
>   
Consistency.
> And one quick last question for further translations.
> TSTRING(BLAH) goes to T_("Blah")
> How should CTSTRING(BLAH) end up ?
>   
CTSTRING(BLAH) would technically become T_("Blah").c_str() Can't vouch 
for its correctness though.

Great work!

Re: [dcplusplus-devel] Some more translations

[Jacek S. <arn...@gm...>]

> In HubFrame the column uses "Nick" for "User name".  All the other frames use "User".  Not really to sure about this one, because it works "as is" just thought i should mention it.
I think the difference is that in the hub frame, each line is about a user, so nick says which piece
of information about the user we're displaying in that particular column, whereas in the other
places we happen to use the nick as an simple (and ambiguous) way of identification but conceptually
we want to know who the user is...

> In PublicHubsFrame.cpp, the TSTRING(HUBNAME) goes to "Name".  Should this stay as Name, or become Hub Name ?
Name is fine

> Trying to convert the columns in HubFrame.cpp an error came on this line, which i wasn't sure how to fix correctly, so i reverted my changes until a solution comes up (i have got a backup of it though). (Line 120 in svn694).
> filterType->addValue(TSTRING_I(columnNames[j]));
As David says, T_ is fine.

> In FinishedFrameBase.h TSTRING(REMOVE) translates to "&Remove" but all others in that area don't have the ampersand, so should that one or not ? I would think not, as "&Remove" is used on buttons and i think it's just been reused, and over looked.  So i left this one unchanged.
Add & to the other ones as well if it's a menu...

> In FavHubProperties.cpp the string "Hub address cannot be empty." has a fullstop at the end, as you can see.  But since no other strings have this, should it be dropped for consistency, or left, with the intention of more missing fullstops being added to other strings in the future ?
Without full stops looks better to me if it's a simple one-liner.

> I also noticed weird behaviour in ADLSearch
> When change a entry from File to Directory, it wipes the Min Size, but not the Max Size.
> When change a entry from File to Full path, it leaves both Min Size and Max Size.
> So what is the right behaviour, wiping Min Size in both places, but leaving Max Size.  Wiping both Min Size and Max Size.  Or leaving both ?
I guess it should wipe both in case it's a directory and not wipe in the other cases, but I've never
used adl so I wouldn't know =)


> And one quick last question for further translations.
> TSTRING(BLAH) goes to T_("Blah")
> How should CTSTRING(BLAH) end up ?
CT_ (which is a new macro: "#define CT_(String) T_(String).c_str()")

I noticed though that CTSTRING is used in the wrong places often - it should only be used when a
LPCTSTR is needed (raw c pointer to string), so first try T_, and if that gives compile errors use
CT_...in other words, if the method being called takes a tstring, use T_ and not CT_...

> 
> thanks MikeJJ

On a separate note; should it be pothead, mikejj or Michael Jones that gets credited?


/J

Re: [dcplusplus-devel] Some more translations

[Michael J. <mrm...@ho...>]

>> In FinishedFrameBase.h TSTRING(REMOVE) translates to "&Remove" but all o=
thers in that area don't have the ampersand, so should that one or not ? I =
would think not, as "&Remove" is used on buttons and i think it's just been=
 reused, and over looked.  So i left this one unchanged.
> Add & to the other ones as well if it's a menu...
Okay, i'll leave them for the moment, until i can think off good accelerato=
rs for the other ones, as it'll help finding some right click menu's in fut=
ure. :)

> I guess it should wipe both in case it's a directory and not wipe in the =
other cases, but I've never
> used adl so I wouldn't know =3D)
I'll play with Full Path, to see if it uses Filesize then.  If not, might a=
s well be wiped from that one as well.

> I noticed though that CTSTRING is used in the wrong places often - it sho=
uld only be used when a
> LPCTSTR is needed (raw c pointer to string), so first try T_, and if that=
 gives compile errors use
> CT_...in other words, if the method being called takes a tstring, use T_ =
and not CT_...
hehe, now you said that, i'm glad i've not got around to doing any CTSTRING=
S yet.  Compiler errors are a good way to see if it needs it or not.  In my=
 current working copy i used compiler errors to see which files can have th=
e ResouceManager.h include deleted. (i failed at moving the ones from the l=
ast patch to a different directory, so now my working copy has half submitt=
ed and half not submitted changes :P).

> On a separate note; should it be pothead, mikejj or Michael Jones that ge=
ts credited?
I would prefer MikeJJ please, since i'm trying to ditch the nick Pothead.  =
I've also been meaning to ask if the "Pothead" in the About Box and changel=
og could be changed to MikeJJ for a while, but was waiting for the right ti=
me to ask ;)

Also from my notes of current working copy, might as well ask this one now:

UserInfoBase.h needed #include  adding to get rid of these errors:
win32\/UserInfoBase.h:96: error: 'Text' has not been declared
is that the best thing to include ? as it also works including WinUtil.h

thanks MikeJJ

_________________________________________________________________
Telly addicts unite!
http://www.searchgamesbox.com/tvtown.shtml=

Re: [dcplusplus-devel] Some more translations

[Jacek S. <arn...@gm...>]

> I would prefer MikeJJ please, since i'm trying to ditch the nick Pothead.  I've also been meaning to ask if the "Pothead" in the About Box and changelog could be changed to MikeJJ for a while, but was waiting for the right time to ask ;)
Getting older? =)

> Also from my notes of current working copy, might as well ask this one now:
> 
> UserInfoBase.h needed #include  adding to get rid of these errors:
> win32\/UserInfoBase.h:96: error: 'Text' has not been declared
> is that the best thing to include ? as it also works including WinUtil.h
Always include the file that declares the class, in this case Text.h...

/J