James Ross wrote:
>> What's the deal with the min/max comment? afair windows.h defines ugly
>> versions of min/max?
>
> It was all commented out, and all the places which use std::min or std::max
> are wrapped in parentheses as the comment notes (except one). I don't think
> it needs to have the commented-out defines, but the comment could be left
> instead?
Well, if it works without and uses the c++ version that's fine (and then I want neither comment nor
undefs). But as far as I can see, there are no parentheses in the dc++ code that uses min/max and I
don't want them there either (harder to read), so unless I'm missing something cruical (mind that
most of the time the dc++ code doesnt use the the std:: prefix, so searching for that won't be
enough), this part of the patch won't go in...
> Thanks, most of it was making it link with openssl (and compiling openssl
> with the right flags). :)
I would get rid of openssl (don't like its license), but I'm low on alternatives. gnutls seemed
trickier to compile because of the additional dependencies, and I'm guessing it won't work very well
with msvc...
/J
|
