Steven Sheehy wrote:
> Use the standardized C99 types. This is our fault for not checking it
> when we added the *nix fast hash. :D
ok. ever considered mmap?
> Use strtoll instead of atoll to enable build on HPUX
Ok.
> Fixes the disconnected string showing in the transfers pane before the
> no slots available status.
I discussed this patch with razzloss and we both came to the conclusion that its the responsability
of the gui to tell which error messages to display from where...besides, I'm anticipating some
changes to the transfer view now that we have segmented downloading in the core...
> Adds an option to not follow symbolic links on *nix systems. Sometimes
> following links can be problematic so this option is necessary for these
> situations.
Ok. At some point I really have to make the settings stuff a little less centralized...technically
this could be implemented for win32 as well I think, but I don't remember the exact semantics of
shell links with regards to directories...
> Currently, if the Text::convert() encounters a conversion where the from
> and to encodings are the same, it returns the initial string with no
> conversion taking place. As I found out, this causes problems where the
> text that says it is utf-8 isn't actually valid utf-8. In this case,
> chat messages would not appear in the GUI since GTK+ won't display or
> convert invalid utf-8. To remedy this, the text conversion functions
> need to validate the text even if their encoding implies that no
> conversion is necessary. I moved these checks into the WIN32 blocks.
> Feel free to delete them altogether if you think you need to validate on
> windows as well.
I left them as is for now, although I guess at some point the win32 version should make the
validation as well...apart from validation it should also make normalization to be adc compliant but
that's an issue for a later date...
> Description from original patch writer:
>
> My computer is connected to 2 huge LANs and the internet.
> Respectively, the outside world knows it by 3 different IPs.
While the patch itself seems fine, I'll be needing agreement from the original patch author before I
add this...I'd also like to know who it was that wrote it in order to give due recognition (if the
author wants)...
/J
|
