dcplusplus-devel

[dcplusplus-devel] patch: let windows draw ListView arrows

[poy <po...@12...>]

Common Controls 6 provides a nice way to draw ListView arrows automatically, 
so this patch uses it. now arrows aren't as ugly, and the down arrow is 
drawn correctly.
i had a little trouble with 2 defines, which were in the psdk but not in my 
MinGW.

by the way, i saw this being used in a mod of DC++ a long time ago (can't 
remember which), but it's not like it really matters...

poy 

Re: [dcplusplus-devel] patch: let windows draw ListView arrows

[Jacek S. <arn...@gm...>]

Ok, this should go to the smartwin widget instead...along with a version check function to
aspectcontrol for example (or some better place maybe, ideally it would be static and defined in a
.cpp file)...

/J

poy wrote:
> Common Controls 6 provides a nice way to draw ListView arrows
> automatically, so this patch uses it. now arrows aren't as ugly, and the
> down arrow is drawn correctly.
> i had a little trouble with 2 defines, which were in the psdk but not in
> my MinGW.
> 
> by the way, i saw this being used in a mod of DC++ a long time ago
> (can't remember which), but it's not like it really matters...
> 
> poy
> 
> 
> ------------------------------------------------------------------------
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems?  Stop.
> Now Search log events and configuration files using AJAX and a browser.
> Download your FREE copy of Splunk now >> http://get.splunk.com/
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> dcplusplus-devel mailing list
> dcp...@li...
> https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel

Re: [dcplusplus-devel] patch: let windows draw ListView arrows

[poy <po...@12...>]

> Ok, this should go to the smartwin widget instead...along with a version 
> check function to
> aspectcontrol for example (or some better place maybe, ideally it would be 
> static and defined in a
> .cpp file)...
>
> /J

i did it in win32/ and used a bool in WinUtil because DC++ already checks 
the Common Controls version on startup, and if the version is too old it 
displays a MessageBox.

or should i move the whole checkCommonContrlols() function (along with its 
MessageBox) in smartwin/ ? if it's static the MessageBox would appear only 
once so yeah that should also work.

poy 

Re: [dcplusplus-devel] patch: let windows draw ListView arrows

[Jacek S. <arn...@gm...>]

> i did it in win32/ and used a bool in WinUtil because DC++ already checks 
> the Common Controls version on startup, and if the version is too old it 
> displays a MessageBox.
> 
> or should i move the whole checkCommonContrlols() function (along with its 
> MessageBox) in smartwin/ ? if it's static the MessageBox would appear only 
> once so yeah that should also work.
Well, maybe just create a function that loads the version number in smartwin and then have dc++ use
that function to do the check... if the dc++ smartwin is ever released separately, it's not sure
that all apps will need the new controls...

/J

Re: [dcplusplus-devel] patch: let windows draw ListView arrows

[poy <po...@12...>]

here, new patch.
- the function now uses SmartWin::LibraryLoader.
- moved the MessageBox to MainWindow, and its string can be translated.
- played with some includes...

poy

>> i did it in win32/ and used a bool in WinUtil because DC++ already checks
>> the Common Controls version on startup, and if the version is too old it
>> displays a MessageBox.
>>
>> or should i move the whole checkCommonContrlols() function (along with 
>> its
>> MessageBox) in smartwin/ ? if it's static the MessageBox would appear 
>> only
>> once so yeah that should also work.
> Well, maybe just create a function that loads the version number in 
> smartwin and then have dc++ use
> that function to do the check... if the dc++ smartwin is ever released 
> separately, it's not sure
> that all apps will need the new controls...
>
> /J
>
>