dcplusplus-devel — Developer's list

Re: [dcplusplus-devel] dont send me no more emails

[Fredrik U. <ul...@gm...>]

Then unsubscribe to the list.

On Oct 30, 2007 10:51 PM, ROBERT KING <dob...@ho...> wrote:
> im getting to many
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems?  Stop.
> Now Search log events and configuration files using AJAX and a browser.
> Download your FREE copy of Splunk now >> http://get.splunk.com/
> _______________________________________________
> dcplusplus-devel mailing list
> dcp...@li...
> https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel
>
>



-- 
Fredrik Ullner

[dcplusplus-devel] dont send me no more emails

[ROBERT K. <dob...@ho...>]

im getting to many=

Re: [dcplusplus-devel] patch: context menus handling

[Jacek S. <arn...@gm...>]

poy wrote:
> little fix for context menus that were always supposed to be handled (eg
> when right-clicking in a chat, there was no menu).
ok. at some point a better method should be devised for separating the return value from handled or
not handled...

/J

Re: [dcplusplus-devel] patch: Appearance2Page's font

[Jacek S. <arn...@gm...>]

nice.
/J

poy wrote:
> makes Appearance2Page use SmartWin::FontPtr instead of HFONT.
> 
> poy

Re: [dcplusplus-devel] patch: stats frame

[Jacek S. <arn...@gm...>]

poy wrote:
> fixes in stats frame:
> - now pens are class members, thanks to your nice changes. ;)
> - added a status bar, it was crashing otherwise... may be related to the
> previous tooltip fix...
wouldn't that be an npe because the bar was not initialized? anyway, status bars for everyone is ok.

> as for the background color, it's been fixed in last commit. :)
> however, the flickering-on-resize is back.
Yup, a proper fix would require some investigation...

[dcplusplus-devel] patch: context menus handling

[poy <po...@12...>]

little fix for context menus that were always supposed to be handled (eg 
when right-clicking in a chat, there was no menu).

poy 

[dcplusplus-devel] patch: Appearance2Page's font

[poy <po...@12...>]

makes Appearance2Page use SmartWin::FontPtr instead of HFONT.

poy

[dcplusplus-devel] patch: stats frame

[poy <po...@12...>]

fixes in stats frame:
- now pens are class members, thanks to your nice changes. ;)
- added a status bar, it was crashing otherwise... may be related to the 
previous tooltip fix...

as for the background color, it's been fixed in last commit. :)
however, the flickering-on-resize is back.

poy 

Re: [dcplusplus-devel] patch: tooltips fix

[Jacek S. <arn...@gm...>]

poy wrote:
> this is a fix for tooltips showing up once and then disappearing
> forever; the WTL version had the same problem for some time, and the
> solution was to forward mouse messages to the tooltip.
> 
> i've used addFilter() the same way it's used in MainWindow to catch
> messages, i'm not sure if it was the right way to do it... but it works. :)
looks good to me...a possible downside is that _all_ status bars get _all_ mouse events this way,
instead of just the visible / active ones...hm...

/J

Re: [dcplusplus-devel] patch: bgcolor in settings fix

[Jacek S. <arn...@gm...>]

poy wrote:
> fixed the example box in settings > colors & sounds; the background
> color wasn't displayed correctly.
ok

> 
> i've also been trying to change the background color in Stats Frame (it
> shouldn't stay white, but it should use the colors chosen in settings)
> but the best i could do is get a black background...
Hm, try again after today's commit, it plays with brushes and stuff.. I can imagine that the correct
option would be to stop background redraw (noEraseBackground) then in onPaint do a fillRectangle
with a correctly colored brush...

/J

[dcplusplus-devel] patch: tooltips fix

[poy <po...@12...>]

this is a fix for tooltips showing up once and then disappearing forever; 
the WTL version had the same problem for some time, and the solution was to 
forward mouse messages to the tooltip.

i've used addFilter() the same way it's used in MainWindow to catch 
messages, i'm not sure if it was the right way to do it... but it works. :)

poy 

[dcplusplus-devel] patch: bgcolor in settings fix

[poy <po...@12...>]

fixed the example box in settings > colors & sounds; the background color 
wasn't displayed correctly.

i've also been trying to change the background color in Stats Frame (it 
shouldn't stay white, but it should use the colors chosen in settings) but 
the best i could do is get a black background...

poy 

Re: [dcplusplus-devel] Patch: Localised labels out of sync

[Jacek S. <arn...@gm...>]

right, thanks =)

/J

James Ross wrote:
> This fixes the problem with the wrong labels being used in some places.
> Just a typo. Smile emoticon
>  
> -- 
> James Ross

[dcplusplus-devel] Releases...

[Jacek S. <arn...@gm...>]

Given the recent fuss over unstable release being uhm...unstable, here's a possible way to ensure
minimal release testing...

Instead of releasing, I create a branch in svn named something like 0.701-rc. The release manager
(yet to be appointed, not me) builds this branch, offers it to a group of dedicated testers (or on
the web in some obscure place where whiners do not go) and then
releases the version to the public (as unstable) adding a tag in the tags svn folder as is done now.
If there are problems with the release, the problems may either be solved in trunk and then merged
to the branch by the release manager, or fixed in the branch if they no longer apply to trunk
because of further developments.

This of course requires that someone becomes release manager (something that I'm not willing to do),
so if anyone feels inspired and wants to help out, this is the golden chance.

I'm also open to other suggestions that require little management effort on my part.

/J

Re: [dcplusplus-devel] Patch to list recent connected hubs

[Jacek S. <arn...@gm...>]

Fredrik Ullner wrote:
> This patch will add a new window, "Recent hubs". The window will list
> the last connected hubs, and the data will be stored in Favorites.xml.
> The following format is used for Favorites.xml;
> <Recent>
> <Hub Name="" Description="" Server="" Time="" Encoding=""/>
> </Recent>
RecentHubs? (in case we add recentPMs, recentSearches etc)

> Note; A line in MainWindow.cpp is commented out. This is because I was
> unsure on with what application to alter the toolbar .BMPs to keep the
> pictures intact. The line isn't required if it's not desired to have the
> window accessable through the toolbar (and only the menu). However, the
> window's icon will then default to (I believe) the hub icon.
>
> Note2; Each hub is added to the WidgetDataGrid. However, this patch
> doesn't remove the old hub (one that's already in the list, that is, it
> should only be updated) from the WidgetDataGrid. I wasn't sure what
> strategy should be used. Any suggestions?
> 
Is a window really needed for recent hubs? Maybe a menu would be enough (with just the hub name, no
description)...
as to the dupes, I'd update the last accessed time (so if default sort is by last access they move
up to the top once sorting works =), to avoid multiple entries with the same hub.

An upper limit or maximum time from last visit isn't needed?

It would also be nice to have a "session" ability, so that the recent hubs have a flag "connected"
which is set for open hubs when shutting down, so that all open hubs reopen on startup, but I'll
accept the patch without.

/J

Re: [dcplusplus-devel] patch: pens in stats frame

[Jacek S. <arn...@gm...>]

Ok. I'm guessing the long term solution would be to remove the canvas from the pen
object/constructor, then pens could be created once and selected into the dc on demand...it would be
nice to automagically handle the resetting of the previous pen (or other gdi object) in some nice
way as well after using a specific pen, something like a scoped_selector which selects a pen , saves
the old pen (which is returned when setting the new pen) and the resets old pen when the selector
goes out of scope...

/J


poy wrote:
> solving the colors problem the easy way; pens are created and destroyed
> each time they are used.
> 
> poy

[dcplusplus-devel] patch: pens in stats frame

[poy <po...@12...>]

solving the colors problem the easy way; pens are created and destroyed each 
time they are used.

poy 

Re: [dcplusplus-devel] patch: stats frame

[Jacek S. <arn...@gm...>]

Ok. The painting signals will be dealt with later on.

/J

poy wrote:
> finally, 3rd try with the stats frame...
> 
> this time, instead of modifying the onPainting signal so that it
> dispatches the rect, i simply used an onRaw call; then StatsFrame can
> handle WM_PAINT the way it wants to (see the comment next to the onRaw
> call).
> 
> i've still included the previous patch (patch-StatsFrame-pRect.patch),
> just in case.
> 
> and by the way, the following 2 problems are still here, but i wanted to
> see if this way of getting the update rect is ok before going further:
> poy wrote:
>> almost ok, except:
>> - there's flickering when resizing the window, because of the
>> invalidateWidget() in layout() which invalidates everything.
>> - colors are always black, the ::SelectDCPenColor i've used doesn't seem
>> fine... SmartWin's pens can't be "free" (without a canvas attached) so i
>> couldn't find a way to store pens as members of StatsFrame like before
>> in the WTL version.
> Yeah, it used to be the same for brushes...you can either create the pen
> each time you use the
> canvas (I think this is what the smartwin people intended) or change the
> pen class to make it
> standalone (like the brush is now)...technically, you only need the pen
> while drawing so recreating
> it each time shouldn't present any major problems (I think)...
> 
> poy
> 
> 
> ------------------------------------------------------------------------
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems?  Stop.
> Now Search log events and configuration files using AJAX and a browser.
> Download your FREE copy of Splunk now >> http://get.splunk.com/
> 
> 
> ------------------------------------------------------------------------
> 
> _______________________________________________
> dcplusplus-devel mailing list
> dcp...@li...
> https://lists.sourceforge.net/lists/listinfo/dcplusplus-devel

[dcplusplus-devel] patch: stats frame

[poy <po...@12...>]

finally, 3rd try with the stats frame...

this time, instead of modifying the onPainting signal so that it dispatches 
the rect, i simply used an onRaw call; then StatsFrame can handle WM_PAINT 
the way it wants to (see the comment next to the onRaw call).

i've still included the previous patch (patch-StatsFrame-pRect.patch), just 
in case.

and by the way, the following 2 problems are still here, but i wanted to see 
if this way of getting the update rect is ok before going further:
poy wrote:
> almost ok, except:
> - there's flickering when resizing the window, because of the
> invalidateWidget() in layout() which invalidates everything.
> - colors are always black, the ::SelectDCPenColor i've used doesn't seem
> fine... SmartWin's pens can't be "free" (without a canvas attached) so i
> couldn't find a way to store pens as members of StatsFrame like before
> in the WTL version.
Yeah, it used to be the same for brushes...you can either create the pen 
each time you use the
canvas (I think this is what the smartwin people intended) or change the pen 
class to make it
standalone (like the brush is now)...technically, you only need the pen 
while drawing so recreating
it each time shouldn't present any major problems (I think)...

poy 

Re: [dcplusplus-devel] patch: users frame cleanup

[Jacek S. <arn...@gm...>]

Accepted.

poy wrote:
> now, buttons in that frame would be nice...
> 
> poy

[dcplusplus-devel] patch: users frame cleanup

[poy <po...@12...>]

now, buttons in that frame would be nice...

poy

[dcplusplus-devel] Ping

[Jacek S. <arn...@gm...>]

Hi,

this list has been inactive for some time but I revived it today. It will be the preferred place to
send in patches to dc++, as well as discussing development in general.

Regards,
/J

[dcplusplus-devel] patch: help in settings

[poy <po...@12...>]

help button in settings. i moved the handleHelp function from PropPage to 
SettingsDialog.
there's that annoying thing about onRaw's that don't accept void-returning 
functions, so i couldn't get the onRaw and the onClicked to call the same 
handleHelp function (which would have been nicer).

added 3 strings in StringDefs to make the ok-cancel-help buttons in settings 
translatable.

poy 

Re: [Dcplusplus-devel] hublist downloading

[Todd P. <tod...@ve...>]

If you want tech support, please go to the forum - 
http://dcplusplus.sf.net/forum/

The developer's mailing list (dcplusplus-devel) is not a tech support 
forum.

kthxbye.

  - Todd

On Saturday, September 20, 2003, at 11:07  AM, Polo wrote:

> hello i can t download the hublist.Can someone help me?

[Dcplusplus-devel] (no subject)

[Polo <Pol...@ho...>]

hello i can t download the hublist.Can someone help me?