Menu

dbunit Merge Request #30: Feature #200: CachedDataSet has redundant code. (merged)

Merging...

Merged

Something went wrong. Please, merge manually

Checking if merge is possible...

Something went wrong. Please, merge manually

Hans Deragon wants to merge 0 commits from /u/deragon/dbunit/ to master, 2017-10-22

CachedDataSet did not make use of member fields and functions inherited
from AbstractDataSet. Now the code has been simplified, opening the way
for easier maintenance and extension.

IMPORTANT CHANGE: AbstractDataSet.initialize() becomes protected.

This change required that AbstractDataSet.initialize() become
'protected' instead of 'private', so that CachedDataSet could call it
instead of implementing its own duplicate version.

It also required a small renaming of the initialize() function to
initializeFlatDtdDataSet() in FlatDtdDataSet to avoid an interference.
Other classes are not affected.

WARNING:

This change is incompatible with merge request #29. You decide which one
first to merge, then I will make the required changes to the other merge
request to make things compatible.

Commit Date  

Discussion

  • Jeff Jensen

    Jeff Jensen - 2017-07-08

    I suggest combining MR #29 and #30 since they are related and then there is no MR ordering problem.
    However, this one seems good to merge as is so let me know if you prefer to not combine.

     
    • Jeff Jensen

      Jeff Jensen - 2017-09-24

      Hi Hans, want to make any further progress on these? We should finish and merge them!

       
  • Hans Deragon

    Hans Deragon - 2017-10-22

    Ok. I have both FlatDtdDataSet & CacheDataSet fixed. The merge should be simple.

     
  • Jeff Jensen

    Jeff Jensen - 2017-10-22

    Thanks Hans. Did the other subclasses of AbstractDataSet have these issues too? Wondering if these were the only ones or more to do yet.

     
  • Jeff Jensen

    Jeff Jensen - 2017-10-22
    • Status: open --> merged
     
MongoDB Logo MongoDB