Menu ▾ ▴

#1 Check return codes everywhere

open-accepted
nobody
None
5
2005-08-13
2005-07-21
No

Some checks for return codes are missing.

Example:
Please add more error handling for null pointers
from "malloc" in the function "sanitize_path".
http://cvs.sourceforge.net/viewcvs.py/dbacl/dbacl/src/ca
tfun.c?rev=1.1.1.7&view=markup

Discussion

  • Laird Breyer

    Laird Breyer - 2005-07-28
    • status: open --> pending
     
  • Laird Breyer

    Laird Breyer - 2005-07-28

    Logged In: YES
    user_id=678360

    Well spotted, thanks.. I'll pass the code through splint to
    check for others.

    There are only a few places where function return codes are
    ignored on purpose, but thanks for pointing this out.

     
  • SourceForge Robot

    • status: pending --> closed
     
  • SourceForge Robot

    Logged In: YES
    user_id=1312539

    This Tracker item was closed automatically by the system. It was
    previously set to a Pending status, and the original submitter
    did not respond within 14 days (the time period specified by
    the administrator of this Tracker).

     
  • Markus Elfring

    Markus Elfring - 2005-08-13
    • status: closed --> open-accepted
     
  • Markus Elfring

    Markus Elfring - 2005-08-13

    Logged In: YES
    user_id=572001

    Does the tool "splint" find more candidates for correction
    in your source code?

     

Log in to post a comment.