SourceForge has been redesigned. Learn more.
Close

#220 SiteSecurity.cs has some issues and wtfs.

open
None
5
2008-04-07
2008-02-24
nimish123
No

SiteSecurity.cs has some some shady code with regards to case insensitive name comparisions. Testing equality with ToUpper is wierd when string.equals(...,StringComparision.InvariantCultureIgnoreCase) exists. Also, some if(<condition) return true; else return false; type constructs were removed.

In the login code, the logic was convoluted and also repeated itself. I have made some changes to remove some redundant loops; I replaced them with calls to GetUser(userName).

This is in dasBlog 2.0 .

Discussion

  • nimish123

    nimish123 - 2008-02-24

    a patch against revision 806 for SiteSecurity.cs

     
  • Scott Hanselman

    Scott Hanselman - 2008-04-07
    • assigned_to: nobody --> glucopilot
     
  • Tony Bunce

    Tony Bunce - 2008-06-13

    Logged In: YES
    user_id=408799
    Originator: NO

    fixed in codeplex revision 12758

     

Log in to post a comment.