#30 Non allowed characters on !NICK shuts down the bot

[Luiz Castelo-Branco]

Erroneous nickname causes shutting down connection (Socket closed!)

<BotUser> !nick 30T
<DB> Attempting to /nick 30T.
* DB has quit (Client closed connection)

LOGS:
... 432 DB 30T :Erroneous nickname
Server Reported error DB 30T :Erroneous nickname

Obs.: Since the server message of erroneous nick bypasses the chat/channel probably would be better in parsing it as a notice to the user.

[onefang]

Darkbot actually shuts down deliberately in this case. I suspect coz it might have changed it's nick internally already, and would otherwise get confused.

[onefang]

Fixed in commit https://sourceforge.net/p/darkbot/darkbot/ci/b4cf903f75345903af2f4b7b222b960dd546d0e5/

I made a note about reporting the error to the user in the source code, but did not fix that yet. It's in the middle of a large block of code that needs a big rewrite anyway, and we can deal with that then.