#1479 timeout issue over proxy

[Peter]

There is timeout issue over proxy in the libcurl 7.39, the root cause is due to the introduction of "Happy Eyeballs" feature of libcurl leading to waitconnect_getsock() returning 0 unexpectedly somehow over proxy.
The curl code might need to return "GETSOCK_WRITESOCK(0)" as 7.32 if 0 is going to be returned, without impacting the existing "Happy Eyeballs" feature.

http://curl.haxx.se/mail/lib-2013-10/0207.html

@@ -621,17 +621,26 @@ static int waitconnect_getsock(struct connectdata conn,
curl_socket_t sock,
int numsocks)
{
+ int i;
+ int s=0;
+ int rc=0;
+
if(!numsocks)
return GETSOCK_BLANK;

• sock[0] = conn->sock[FIRSTSOCKET];
• for(i=0; i<2; i++) {
• if(conn->tempsock[i] != CURL_SOCKET_BAD) {
• sock[s] = conn->tempsock[i];
• rc |= GETSOCK_WRITESOCK(s++);
• }
• }

/ when we've sent a CONNECT to a proxy, we should rather wait for the
socket to become readable to be able to get the response headers /
if(conn->tunnel_state[FIRSTSOCKET] == TUNNEL_CONNECT)
return GETSOCK_READSOCK(0);

• return GETSOCK_WRITESOCK(0);
• return rc;

Could you please it in the next libcurl version(7.41)?

[Daniel Stenberg]

Thanks, but that diff got all munged here. Can you attach it please?

[Peter]

attach the file, thanks.

[Daniel Stenberg]

I posted a suggested patch to the mailing list, lets continue there: http://curl.haxx.se/mail/lib-2015-02/0198.html

[Daniel Stenberg]

The fix was merged and was confirmed on the list to fix the problem.