Menu

#1440 compile with a OpenSSL without DSA, RSA, or DH

closed-out-of-date
5
2014-12-09
2014-10-24
No

CURL doesn't take into account that OpenSSL could have been compiled without support for RSA, DSA, or DH. I've attached a patch which illustrates how this could be fixed. Please note that I might've missed necessary changes elsewhere in CURL.

1 Attachments

Discussion

  • Daniel Stenberg

    Daniel Stenberg - 2014-10-24
    • assigned_to: Daniel Stenberg
     
  • Daniel Stenberg

    Daniel Stenberg - 2014-10-24

    Thanks.

    I'm not entirely convinced this is something libcurl needs to support. Yes sure, it is easy to add some #ifdefs once but...

    A) that means a different functionality that is completely undocumented for libcurl users unless "someone" also writes docs that explains the effects

    B) we have no tests for this so it'll bitrot and break over time as this is rarely used features we're talking about

    C) adding #ifdefs to code is generally considered a way to make the code less readable so doing so for a one-in-a-million feature might not be a good idea.

    To top it off, not even you (who is one of these rare users with this use case and desire) provide a patch that is complete and that you believe in...

     
  • Mark Kubacki

    Mark Kubacki - 2014-10-24

    Thank your for your feedback.

    I will see if I can address A, B, as well as D with a complete patch. Perhaps it turns out to be not as complex as this issue might implicate.

     
  • Daniel Stenberg

    Daniel Stenberg - 2014-11-03
    • status: open --> pending-needsinfo
     
  • Daniel Stenberg

    Daniel Stenberg - 2014-12-09
    • status: pending-needsinfo --> closed-out-of-date
     
Monday.com Logo