#2 bjnp-runloop.c:376: possible bad if test ?

[dcb]

I just compiled cups-bjnp-1.2.1 with gcc compiler flag -Wlogical-op

It said

bjnp-runloop.c:376:8: warning: logical 'or' of collectively exhaustive tests is always true [-Wlogical-op]

Source code is

      if (errno != EAGAIN || errno != EINTR)

Suggest swap || for &&.

[Louis Lagendijk]

Thanks for the comment. Your observation seems to be correct. Corrected in subversion

[Louis Lagendijk]

Fixed in 1.2.2