Menu

#50 [vhdl] fix and improvements

closed-fixed
nobody
None
5
2008-04-20
2008-04-19
No

Hi,

I discovered a bug that i Introduced which prevent from tagging anything beyond an attribute (something of the form : clk'event ).
The current parsing was looking for a matching "'" but there are never a matching simple quote for those.
Since we only (as far as i know) find single characters between single quotes it is not really important to parse those string.

The default now doesn't tag prototypes, components and local constants and can be tagged by adding the specific flags on the command line.

I also ran the program through valgrind to remove every memory leaks that I found in the vhdl parser.

Every feedbacks are welcome.
Nicolas.

Discussion

  • Nicolas Vincent

    Nicolas Vincent - 2008-04-19

    vhdl parser fix and improvements

     
  • Elliott Hughes

    Elliott Hughes - 2008-04-20

    Logged In: YES
    user_id=1127237
    Originator: NO

    looks good to me. i was a bit confused by some of the now-missing tags shown by "make test", until i noticed that you'd changed the defaults.

    applied as revision 657.

     
  • Elliott Hughes

    Elliott Hughes - 2008-04-20
    • status: open --> closed-fixed
     

Log in to post a comment.