#74 Add arithmetic modulo for sampling large dataset

[Daniel Wagner]

Hello Simon,

I've now committed an initial version of the arithmetic modulo
operation, you can find the changesets here:
https://github.com/kwaxi/csvjdbc/commit/a0c465d6690ecdea38f9d0e40224460a80b44998
https://github.com/kwaxi/csvjdbc/commit/c34451c185de16cd80c21b9fe80e22a555ae6758

On integer types it uses the BigInteger.mod method (w/ second change
.remainder), on real types it uses the BigDecimal.remainder method -
i.e. it accepts negative values, too.

Regards,
Daniel

[Simon Chenery]

Thank you. I merged your changes into CsvJdbc repository.

[Daniel Wagner]

Btw, have you considered to switch to generating

• ExpressionParser.java
• ExpressionParserConstants.java
• ExpressionParserTokenManager.java
• ParseException.java
• SimpleCharStream.java
• Token.java
• TokenMgrError.java

on build? On my fork at GitHub I've set this up using javacc-maven-plugin. I'm sure with Ant something similar can be done.

Using javacc-maven-plugin is the reason why I moved where.jj to a different location.

[Simon Chenery]

Yes I am checking the pom.xml in your github repo ( https://github.com/kwaxi/csvjdbc )

1. Is the following pom.xml tag really necessary?

     <!--This plugin's configuration is used to store Eclipse m2e settings
     only. It has no influence on the Maven build itself. -->
     <plugin>
     ...
     </plugin>

1. I think where.jj should be stored under
   src/main/javacc/org/relique/jdbc/csv/where.jj and not
   src/main/javacc/where.jj. Maven works with both but javacc writes
   generated classes to the same directory as the .jj file by default.
   I would prefer that the classes are in a directory matching the package
   name (org.relique.jdbc.csv) so that eclipse and the javac compiler can find them.