Re: [cssed-devel] cssed-findinfiles-plugin: some problems

[Iago R. <iag...@hi...>]

On Sun, 2004-09-12 at 12:27, Michèle Garoche wrote:
> When changing the base directory for search, the selection is not 
> refresh in the base directory dialog (the field at the bottom), though 
> the right directory is selected.

I think it's now fixed in CVS.

> In the same dialog, the popupmenu does not reflect the last base 
> directory.

Yes, it's a GtkFileSelection dialog and does not implement those bits
itself.

I must wrote support fot this, but I was thinking about to change the
base directory entry, by adding a combo box with the last opened
directories, as in the file browser.

> If the permission is denied to enter a given directory, there is no 
> error message shown to the user, but instead a dialog window shows as 
> if you can enter in it, though the selection does not change. I think 
> first it's very confusing to the user, second it gives a huge 
> impression of insecurity, not good at all for cssed. Here we should 
> have an error message= "You have not the required permissions to access 
> this directory".

Unfortunately it's a GTK bug. THis behaviour is exposed by each
application using the Gtk file selector.

It will be soon deprecated, as the new GtkFileChooser have been released
so I don't think Gtk developers will try a fix of this.

May be we should file a bug in bugzilla. 

> When searching if no match at all is found, there should be a warning 
> for the user, so that it is clear the search has been performed.

Fixed in CVS. Now it's shown a message at search start and end.

> When using the popup menu in the editor window to search for terms and 
> if no term is selected in the current file, there is no refresh of the 
> base directory in the plugin. This only occurs when a search term is 
> selected in the active file.  A bit confusing for me here.

What pop menu entry, "In current base dir" or "In file's base dir" ?

> When the search process encounters a special file, the search takes 
> ages to end and there is a you can have the same error message as in 
> filebrowser plugin, just to reassure the user.

Hmmm! It should not search into special file (mean character devices and
such) as we are passing find the "-type -f" parameter.

Could you tell me how to reproduce it ? or, What kind of special file is
opened by the proccess ?

> More on that later.

Thanks in advance :)

Attached patch with those fixes.
-- 
Iago Rubio   
- Home page    * http://www.iagorubio.com 
- Last project * http://cssed.sourceforge.net         
- GPG Keyserv  * pgp.rediris.es id=0x909BD4DD