Menu ▾ ▴

#44 CSSFactory.registerDefaultMatchCondition() needs to be non-static

Any_version_(please_provide_version_in_description)
closed
nobody
None
1
2015-01-10
2014-09-06
mercury
No

CSSFactory.registerDefaultMatchCondition() is setting static state. I have a project which has multiple DOMs active simultaneously and shared global state doesn't work.

Can you move this into a non-static context? The DOMAnalyser seems to be a good place to keep match conditions.

Discussion

  • mercury

    mercury - 2014-10-09

    Please let us know whether this proposal make sense. We can take up the implementation if we get a green signal.

     

  • Radek Burget

    Radek Burget - 2014-10-10

    Great, you have a green signal. I agree that DOMAnalyzer is a good place for this. However, I prefer maintaining backward compatibility when possible. So my proposal is: keep the registerDefaultMatchCondition() for specifying the system-wide defaults and add a new (e.g. DomAnalyzer.addMatchCondition) for adding/overriding the conditions. Does this make sense?

     

  • Chetan Kothari

    Chetan Kothari - 2014-10-14

    Fixed by PR

     

  • Radek Burget

    Radek Burget - 2014-10-15
    • status: open --> accepted
     

  • Radek Burget

    Radek Burget - 2015-01-10

    Closed in 1.19

     

  • Radek Burget

    Radek Burget - 2015-01-10
    • status: accepted --> closed
     

Anonymous
Anonymous

Add attachments
Cancel