[Csms-bugs] [ csms-Bugs-629954 ] Unable to identify players

SourceForge Headquarters 225 Broadway Suite 1600 San Diego, CA 92101 +1 (858) 422-6466

Bugs item #629954, was opened at 2002-10-28 16:44
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=509508&aid=629954&group_id=65029

Category: Config Files
Group: CVS HEAD
Status: Open
Resolution: None
>Priority: 2
Submitted By: Ross Gardler (rgardler)
Assigned to: Michael Lever (leverm)
Summary: Unable to identify players

Initial Comment:
Manchester United 3 - 0 Everton Played on October 7

Lots of errors, mainly unable to allocate points to players. The
commentary referred to Nistelrooy in various ways!

This probalby requires an editing in the players.xml file. Either the 
players are missing from this file, or the BBC uses alternative names 
for them.

Alternative names are added to the player entry so, for example:
{{{
<player ud="123">
  <firstName type="name">Ruud</firstName>
  <firstName type="initial">R.</firstName>
  <surname type="main">van Nistelrooy</surname>
  <surname type="alternative">Nistlerooy</surname>
  <surname type="BBCMispelling">Nistleroy</surname>
 ...
</player>
}}}

The element with type="main" is the one used as output, however, 
matches will be made on any of the elements. So "Nistleroy" would 
match this entry becasue it is in the list of possible surname, but 
"Nistlrooy" would not match. At present only type="main" is 
meaninful, so other entries should just have a human readable 
descriptive type.

----------------------------------------------------------------------

>Comment By: Michael Lever (leverm)
Date: 2002-11-24 20:16

Message:
Logged In: YES 
user_id=631335

I only passed it back to you, because you said to! I'm happy 
with the result. Your alternative didn't work (produced 
unidentifiable player). This is because (as in the original 
problem) the <firstName type="main"> tag is empty. My 
solultion actually put his whole name (plus the -) in the 
firstName tag. I have altered it back to how I had done it 
before.

----------------------------------------------------------------------

Comment By: Ross Gardler (rgardler)
Date: 2002-11-24 19:55

Message:
Logged In: YES 
user_id=88713

I don't have time to experiment with this just yet so I'm passing it back 
to mlever (no one wants this one!)

When we look for a match any name will be used, however, when the 
name is constructing for printing the first name, or the one with 
attribute type="main" is used. Therefore, (I think) it should be possible to 
get a decent result with:

<player id="601">
<firstName type="main"></firstname>
<firstName type="full">Eduardo
Cesar Daude</firstName>
<firstName type="initial"></firstName>
<surname
type="main">Gaspar</surname>
<surname
type="alternative">Edu</surname>

<registeredTeam>ARS</registeredTeam>
<team>ARS</team>
<position>Midfield</position>
<cost>3.0</cost>
</player>

Might be worth a try, if it doesn't work I'd suggest dropping the priority 
of this bug to the lowest one (and yes you can pass it back to me!) as  
you have a perfectly workable fix and the players database system is 
changing at the moment, I'll try and buid a better system into the next 
version.

----------------------------------------------------------------------

Comment By: Michael Lever (leverm)
Date: 2002-11-24 19:47

Message:
Logged In: YES 
user_id=631335

I have altered the name so that he is now identifiable. The 
result is :

Eduardo Cesar Daude Gaspar - Edu

Obviously this is not an ideal solution, but does produce a 
result which means the player is easily identifiable.

Now reassigned to rgardler in case he can produce a better 
result by atering the xsl file, or if this is acceptable it can be 
closed.

----------------------------------------------------------------------

Comment By: Michael Lever (leverm)
Date: 2002-11-24 19:36

Message:
Logged In: YES 
user_id=631335

Edu is his first name - his full name is Eduardo Cesar Daude 
Gaspar, but he is only ever referred to as Edu. The problem 
can be got round temporarily by altering the players.xml file :

	<player id="601">
		<firstName type="main">Eduardo 
Cesar Daude</firstName>
		<firstName type="initial"></firstName>
		<surname 
type="main">Gaspar</surname>
		<surname 
type="alternative">Edu</surname>		

	<registeredTeam>ARS</registeredTeam>
		<team>ARS</team>
		<position>Midfield</position>
		<cost>3.0</cost>
	</player>

However, this produces the full name "Eduardo Cesar Daude 
Gaspar Edu", which is not particularly pleasant, so if an 
alteration to the xsl file will produce a better result, then that 
would be more desirable.

----------------------------------------------------------------------

Comment By: Ross Gardler (rgardler)
Date: 2002-11-06 20:20

Message:
Logged In: YES 
user_id=88713

Not sure how you intend to do this, I've tried having an empty name and 
I've tried a blank name, neither work.

I think this requries a change in the XSL not players.xml. Give whatever you 
think might work a try. If it fails then assign this bug to me and I'll have a 
look.

----------------------------------------------------------------------

Comment By: Michael Lever (leverm)
Date: 2002-11-06 20:02

Message:
Logged In: YES 
user_id=631335

I will edit the players.xml file in the near future toi see
if this can be rectified.

----------------------------------------------------------------------

Comment By: Michael Lever (leverm)
Date: 2002-11-06 19:41

Message:
Logged In: YES 
user_id=631335

I've checked a few sites and can see no first name for Edu .

----------------------------------------------------------------------

Comment By: Ross Gardler (rgardler)
Date: 2002-11-04 22:05

Message:
Logged In: YES 
user_id=88713

FIxed issues with Man Utd and West Brom players. However, the issue with 
Edu is a little more complicated. Does he really have no first name?

----------------------------------------------------------------------

Comment By: Michael Lever (leverm)
Date: 2002-11-02 16:00

Message:
Logged In: YES 
user_id=631335

Same problem occurs with players who are only referred by
their surnames. Eg Arsenal's 'Edu' does not have a first
name and is referred to as "N/A Edu" in a recent game (ARS v
BLA 26/10/02).

----------------------------------------------------------------------

Comment By: Ross Gardler (rgardler)
Date: 2002-10-28 16:48

Message:
Logged In: YES 
user_id=88713

Also:

Newcastle 2 - 1 West Brom Played on October 5

Jason Roberts was shown as #N/A Roberts.

This means the first name is missing in the players.xml file.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=509508&aid=629954&group_id=65029