[Cscope-devel] a small issue in contrib/ocs and a fix

[Temp V. <tem...@gm...>]

Hello,

It looks like the recent commit [bb7f25fa] "contrib/ocs: Fix bashims
(Closes: #480591)"
has introduced a small issue, at least covscan reports the following:

1. /usr/bin/ocs:213:13: warning[SC2039]: In POSIX sh, printf -I is
undefined.
#    for i in `cat ${theInc}`
#    do
#        printf "-I $i "
#    done

Indeed (standard bash-5.0.17):

$ printf "-I test "
bash: printf: -I: invalid option
printf: usage: printf [-v var] format [arguments]

but this works fine:

$ printf -- "-I test "
-I test <no lf>

I believe, a small patch like this would fix this small issue:

--- contrib/ocs.old        2021-04-28 00:21:22.118029152 +0200
+++ contrib/ocs        2021-04-28 00:21:42.417089321 +0200
@@ -210,5 +210,5 @@
         for i in `cat ${theInc}`
         do
-            printf "-I $i "
+            printf -- "-I $i "
         done
     fi

Best regards,
Vladis