From: Paul J. <pau...@us...> - 2005-04-25 14:11:04
|
Update of /cvsroot/cruisecontrol/cruisecontrol/main/src/net/sourceforge/cruisecontrol/publishers In directory sc8-pr-cvs1.sourceforge.net:/tmp/cvs-serv15626/main/src/net/sourceforge/cruisecontrol/publishers Modified Files: SCPPublisher.java HTMLEmailPublisher.java Log Message: Removed several coding issues pointed out by IntelliJ. Mostly redundant initializations, unused private members, etc. Index: SCPPublisher.java =================================================================== RCS file: /cvsroot/cruisecontrol/cruisecontrol/main/src/net/sourceforge/cruisecontrol/publishers/SCPPublisher.java,v retrieving revision 1.9 retrieving revision 1.10 diff -u -r1.9 -r1.10 --- SCPPublisher.java 24 Apr 2005 15:17:59 -0000 1.9 +++ SCPPublisher.java 25 Apr 2005 14:10:24 -0000 1.10 @@ -217,7 +217,7 @@ String dir, String file) { - String argValue = new String(); + String argValue = ""; if (user != null && host != null) { argValue = user + "@" + host + ":"; Index: HTMLEmailPublisher.java =================================================================== RCS file: /cvsroot/cruisecontrol/cruisecontrol/main/src/net/sourceforge/cruisecontrol/publishers/HTMLEmailPublisher.java,v retrieving revision 1.37 retrieving revision 1.38 diff -u -r1.37 -r1.38 --- HTMLEmailPublisher.java 16 Feb 2005 05:09:17 -0000 1.37 +++ HTMLEmailPublisher.java 25 Apr 2005 14:10:24 -0000 1.38 @@ -251,8 +251,7 @@ relativePathToXslFile = relativePathToXslFile.trim(); boolean appending = relativePathToXslFile.startsWith("+"); - String[] newXSLFileNames = null; - + if (appending) { relativePathToXslFile = relativePathToXslFile.substring(1); } @@ -266,7 +265,7 @@ } else { i = 0; } - newXSLFileNames = new String[i + numTokens]; + String[] newXSLFileNames = new String[i + numTokens]; System.arraycopy(xslFileNames, 0, newXSLFileNames, 0, i); while (st.hasMoreTokens()) { |