RE: [Cruisecontrol-devel] rather large commit

[Jeffrey F. <JFr...@al...>]

Done.

-----Original Message-----
From: Klaus Scharpf [mailto:kla...@in...]
Sent: Friday, May 23, 2003 10:33 AM
To: 'Cruisecontrol-Devel (E-mail)'
Subject: RE: [Cruisecontrol-devel] rather large commit


> If we're going to have a bunch of defaults, then it seems like you could
> default the multiple attribute of the antbuilder to 1 as well.
.. and why not use the normal defaults for Ant, i.e. use "build.xml" as the
default
name for the build file, and be able to use the default target as specified
in
the Ant script. This would mean that the minimal config.xml would look more
like this:

<cruisecontrol>
  <project name="cc-test">
    <schedule>
      <ant/>
    </schedule>
    <modificationset>
      <vss vsspath="path" login="" />
    </modificationset>
  </project>
</cruisecontrol>



-----Original Message-----
From: cru...@li...
[mailto:cru...@li...] On Behalf Of
Jeffrey Fredrick
Sent: Thursday, May 22, 2003 8:02 PM
To: Cruisecontrol-Devel (E-mail)
Subject: [Cruisecontrol-devel] rather large commit



Just a heads-up that I just made a rather large commit (see below for
affected files and checkin comment). The changes should all be backwards
compatible.

The goal was to address the ease of use issue somewhat by reducing the
number of elements that need to be configured.  If I've figured it out right
the minimal config.xml should look something like:

<cruisecontrol>
  <project name="cc-test">
    <schedule>
      <ant buildfile="build.xml" target="all" multiple="1" />
    </schedule>
    <modificationset>
      <vss vsspath="path" login="" />
    </modificationset>
  </project>
</cruisecontrol>

Comments, questions, suggestions welcome.

(Documentation changes to follow)

Jtf

CVS: 	src/net/sourceforge/cruisecontrol/CruiseControlController.java 
CVS: 	src/net/sourceforge/cruisecontrol/ModificationSet.java 
CVS: 	src/net/sourceforge/cruisecontrol/PluginXMLHelper.java 
CVS: 	src/net/sourceforge/cruisecontrol/Project.java 
CVS: 	src/net/sourceforge/cruisecontrol/ProjectXMLHelper.java 
CVS: 	src/net/sourceforge/cruisecontrol/Schedule.java 
CVS: 	src/net/sourceforge/cruisecontrol/bootstrappers/VssBootstrapper.java

CVS: 	test/net/sourceforge/cruisecontrol/MockProject.java 
CVS: 	test/net/sourceforge/cruisecontrol/ModificationSetTest.java 
CVS: 	test/net/sourceforge/cruisecontrol/PluginXMLHelperTest.java 
CVS: 	test/net/sourceforge/cruisecontrol/ProjectXMLHelperTest.java 
CVS: 	test/net/sourceforge/cruisecontrol/ScheduleTest.java 
CVS:
test/net/sourceforge/cruisecontrol/bootstrappers/VssBootstrapperTest.java 
CVS: test/net/sourceforge/cruisecontrol/publishers/EmailPublisherTest.java 
CVS: ----------------------------------------------------------------------

Major goal: improve ease of use by adding default values and reducing number
            of required attributes and elements

  ProjectXMLHelper - Schedule is now a plugin
                   - ModificationSet & Schedule are created using
configurePlugin
                   - validate called no ModificationSet & Schedule
                   - interval & quietPeriod no longer required attributes
                   - bootstrapper, log and publishers no longer required
elements
                   - logDir now defaults to "logs/projectName"

  Schedule - interval has default value of 300 seconds (5 minutes)
           - validate fails if there is not at least on builder

  ModificationSet - quietPeriod has default value of 60 seconds
                  - validate fails if there is not at least on sourcecontrol

  PluginXMLHelper - added skipChildElement flag which allows plugins like
                    Schedule and ModificationSet to be configured without
                    configuring their child elements

  Project - interval now comes from Schedule
          - extracted checkLogDirectory so it can be overriden by
MockProject

  VssBootstrapper - updated message with correct attribute name

  CruiseControlController - added TODO comment

  test/**/*.java - updated to match




-------------------------------------------------------
This SF.net email is sponsored by: ObjectStore.
If flattening out C++ or Java code to make your application fit in a
relational database is painful, don't do it! Check out ObjectStore. Now part
of Progress Software. http://www.objectstore.net/sourceforge
_______________________________________________
Cruisecontrol-devel mailing list Cru...@li...
https://lists.sourceforge.net/lists/listinfo/cruisecontrol-devel



-------------------------------------------------------
This SF.net email is sponsored by: ObjectStore.
If flattening out C++ or Java code to make your application fit in a
relational database is painful, don't do it! Check out ObjectStore.
Now part of Progress Software. http://www.objectstore.net/sourceforge
_______________________________________________
Cruisecontrol-devel mailing list
Cru...@li...
https://lists.sourceforge.net/lists/listinfo/cruisecontrol-devel


-------------------------------------------------------
This SF.net email is sponsored by: ObjectStore.
If flattening out C++ or Java code to make your application fit in a
relational database is painful, don't do it! Check out ObjectStore.
Now part of Progress Software. http://www.objectstore.net/sourceforge
_______________________________________________
Cruisecontrol-devel mailing list
Cru...@li...
https://lists.sourceforge.net/lists/listinfo/cruisecontrol-devel