RE: [Cruisecontrol-devel] Monitoring long running build

[Igor S. <ISemenko@MIRATECH.UA>]

Note that XmlLoggerWithStatus class (possibly as cruisecontrol.jar)
should  be placed into ant's lib directory in case you use antScript
attribute.


Igor Semenko,=20
Software Developer
Miratech Ltd.=20
+38 044 206 4090 ext. 6989
ise...@mi...

-----Original Message-----
From: Joris Kuipers [mailto:kui...@xs...]=20
Sent: Monday, September 27, 2004 1:29 PM
To: Igor Semenko
Cc: cru...@li...; ig...@se...
Subject: Re: [Cruisecontrol-devel] Monitoring long running build

> Our build takes around 25 minutes to complete, this is why it is=20
> sometime important to see what exactly CC is doing. We came up with a=20
> custom ant logger (extending XmlLogger) which adds information about=20
> ant target currently running to the buildstatus snippet. See attached=20
> screenshot to get an idea.
>
> Do you think it worth to have this class in a contrib dir at least?

I like the idea and I am sure that there are other users who could
benefit from something like this.

I'm just wondering if your particular implementation isn't very
inefficient: for every start-event you read the status file, recreate
it, write the entire content including the one extra line you've added
and close it. And the writer isn't even buffered...
Wouldn't it be possible to keep the buildstatus file open during the
life of the logger, and to just write the new content to the open file
handle?
You can close the file on the buildFinished-event.

There might be a special reason why you chose this approach but if there
isn't, I'd recommend to implement this small change. If you also remove
all the code that's commented out, I'd be happy to add the logger to the
contrib section.

BTW, I didn't check if your solution conflicts with Jeffrey's new
BuildListener implementation, but I'll make sure to do so before adding
this as a contribution.

Joris