#478 Fade out spell effects.

[Sebastian Andersson]

When a spell is cast in darkness, the spell effect would often be kept in the client's Fog of War.

This doesn't completely fix the issue, but it does make it less common.

Remaining problems are:

• If the player moves so the spell effect ends up out of sight, it will still be stuck there in the FoW.
• If an object burns up, the FoW will contain its smoke.
• The tiles' darkness will still be different compared to the player just moving away from it.

[Kevin Zheng]

Thanks for the contribution.

1. Why does the if statement check !QUERY_FLAG(op, FLAG_LIFESAVE)?
2. Consider putting the object_remove/object_free_drop_inventory call in an else, and remove the return in the if. This clarifies the intent that there are two separate branches.

[Sebastian Andersson]

1: I picked it up from move_cone, where a FLAG_LIFESAVE check is used to avoid removing the spell effect if set, but I now see that happens before the call to remove_or_fade_out, so it should be removed.

2: Yes, good suggestion.