Menu

#289 Add label for currently open container

open
nobody
None
5
False
2022-12-06
2022-12-03
Saiapatsu
No

Right now, to my knowledge, the "ground" pane is always labeled "Ground:", regardless of whether you are currently over an open container, in a vehicle or doing neither of these things.

I request that the server tell the client what the ground pane is supposed to be, in the same way it already exports the player's name or the current activity (spell, skill etc.)
If it's the ground, say "Ground". If a deposit box is currently open, say "deposit box". If the player is in a vehicle, the name of the vehicle, etc.

I'm not sure how this should interact with containers in the inventory, which open as a tree view instead of showing up in the ground pane.
Regardless, this idea came to me when considering #244, which proposes crafting by putting items in a virtual container that may or may not show up as the ground pane. It would be silly to label it "Ground:" when everything still stays in your inventory.

This will also require updating the clients to use the provided container name and updating all GTK client layouts to contain a label for the container name.

Discussion

  • Saiapatsu

    Saiapatsu - 2022-12-03

    In the absence of an Edit button on the initial ticket:
    s/#244/#288/

     
  • ChristopherPH

    ChristopherPH - 2022-12-06

    Although it isn't a simple string passed from the protocol, the information is all available to the client (since I have this feature in my 'work in progress' windows only client). I use the information to show the open container as a popup window, titled with the container name.

    Between the item location field and the item flags, you can test if:

    • The item is a container and is open (open is one of the item flags, and only containers can be opened)
    • The item is on the ground (location is 0)
    • The item is carried by the player (location matches player tag)

    This does require extra logic to save the item that has the open flag, then test any flag changes on the item to see if its closed (or another item becomes opened) but it is possible to implement this feature without a protocol change.

    However, a protocol change would make life much easier.

     

Log in to post a comment.

MongoDB Logo MongoDB