Menu

#885 Client compilation failure on big-endian architectures

2.x
closed
client (8)
5
2021-07-21
2021-01-14
Gwyn Ciesla
No

builddir/build/BUILD/crossfire-client-1.75.0/gtk-v2/src/image.c: In function 'create_map_image':
/builddir/build/BUILD/crossfire-client-1.75.0/gtk-v2/src/image.c:167:31: error: 'ny' undeclared (first use in this function)
167 | for (i=0; i < width * ny; i+= 4) {

Discussion

  • Kevin Zheng

    Kevin Zheng - 2021-01-14
    • status: open --> analyzed
     
  • Kevin Zheng

    Kevin Zheng - 2021-01-14

    Thank you for the report. In the future, please be more clear: I did not know what 'FTBFS' (fails to build from source) and 's390x' (some Linux architecture code) meant. In addition, when reporting issues like these, it is most helpful if you report your compiler and version, operating system/distribution and architecture.

    In this case, it is pretty clear that the SDL client code does not build on big-endian systems. Unfortunately, I don't have the hardware to test the changes.

    Could you please disable SDL in your build and try again?

     
  • Kevin Zheng

    Kevin Zheng - 2021-01-14
    • labels: --> client
    • summary: 1.75.0 FTBFS on s390x --> Client compilation failure on big-endian architectures
     
  • SilverNexus

    SilverNexus - 2021-01-14

    Should be fixed in r21770.
    I had fiddled with some variables and such when changing stuff recently, and apparently I missed a variable name refactor in the big-endian code.

     
  • SilverNexus

    SilverNexus - 2021-01-14
    • status: analyzed --> patched
    • assigned_to: SilverNexus
     
  • Gwyn Ciesla

    Gwyn Ciesla - 2021-01-19

    That works, thank you!

     
  • Nicolas Weeger

    Nicolas Weeger - 2021-07-21
    • status: patched --> closed
     

Log in to post a comment.