#648 item power ignored from certain items

1.72.0
closed
server (366)
5
2017-08-13
2009-01-19
Chadoth
No

item_power isn't affected by the item_power of ranged weapons. For example, your item power before applying a ranged weapon that has item_power + with a given set of gear is the same as your item power with the ranged weapon applied and the same given gear.

Discussion

  • Chadoth

    Chadoth - 2009-01-19

    This might have to do with ranged weapons only being 'readied', not 'applied'.

     
  • Chadoth

    Chadoth - 2009-01-19

    the same thing also happens with talismans...talisman of the unified mind has item_power+4 but applying it doesn't change your item power at all.

     
  • Chadoth

    Chadoth - 2009-01-19
    • summary: ranged weapon item power ignored --> item power ignored from certain items
     
  • Mark Wedel

    Mark Wedel - 2009-02-10

    I suspect it is related to ready vs applied. Same is perhaps true for talismans.

    I'd have to look at the code - I suspect for bows, this isn't much an issue - why the benefit may be there for hitting a target, I'm not sure if other benefits the bow has would translate to the character (eg, stat bonuses or resistances).

    It may therefor be a bug that bows have an item power at all.

     
  • Lalo Martins

    Lalo Martins - 2009-02-11
    • labels: --> server
     
  • Kevin R. Bulgrien

    I'm not sure it is so simple as not counting some item power. I have a character on Invidious that can apply 12 itempower when he is only level 7, but, the order the items are applied makes a difference on whether the extra item power can be worn or not.

    Items: long sword +2 (1), bow of Auriga (4), plate mail +2 (1), cloak of beguilement (2), jack boots of steel (2), gloves of Sorig (2), Paladin's holy symbol (1).

    Say I have plate, helmet, cloak, boots, and gloves on (total item power 7), I cannot equip the bow or holy symbol, so it is counting the bow item power for purposes of testing if apply is possible.

    So now I unequip the cloak and boots (total item power 3). Now I can equip the bow (total item power = 7). I cannot equip the holy symbol, but I can equip both the cloak and boots (total item power 11). If I now deselect the gloves, I can equip the holy symbol and then the gloves (total item power 12) The sword will not apply. The bow might not be counting for some checks, but for others it is since the holy symbol should have applied if it were not counting at all.

    This characters items are presently limited still so we cannot see if it is possible to apply more than 4 extra (which is what the bow is), but the bug is a bit more complex than simply the bow item power not counting. The order that things are applied makes a difference what you can equip.

     
  • Kevin R. Bulgrien

    Doh... its not just the bow that's messed... 12 - 7 is 5... so this character had more item power equipped over max than the bow is worth.

     
  • Kevin R. Bulgrien

    Oh, and I do have an Amulet of Shielding (1). The cloak, gloves, and boots are not universally broken. If I have the bow, plate, holy symbol, amulet applied for a total of 7 item power, I can apply two more of either the boots (2), gloves (2), or cloak (2), but not all three. It appears I am capped out at (12) since applying the other one would put me at (13).

     
  • SilverNexus

    SilverNexus - 2017-08-10

    Reproducible using current client/server (r20479). Problem seems to be that certain items (for example, bow of Auriga) only count their item power when you try to apply them. After they are applied, the item power doesn't count toward total item power.
    All of the item power checks seem to be in apply_special(), so any apply effects that circumvent it are either the result of incorrectly updated item power or a skipped check.
    I'm thinking its the former. I got to the end of Kevin Bulgrien's step-by-step above and checked the skill command. It thinks I'm using 7 item power, when I'm wielding 12.

     
    Last edit: SilverNexus 2017-08-10
  • SilverNexus

    SilverNexus - 2017-08-10
    • assigned_to: SilverNexus
    • Group: --> 1.72.0
     
  • SilverNexus

    SilverNexus - 2017-08-10

    The problem appears to have been that fix_object was not totaling the item power for bows and skill tools in its item_power calculation. Should be fixed in r20480.

     
  • SilverNexus

    SilverNexus - 2017-08-10
    • status: open --> patched
     
  • SilverNexus

    SilverNexus - 2017-08-13
    • status: patched --> closed
     
  • SilverNexus

    SilverNexus - 2017-08-13

    Tried to follow the order from the comments. It appears to have fixed the issue, as both bows and skill tools now count for item power while equipped.

    Closing the issue.

     

Log in to post a comment.