Double no-errors dialog in GUI

[Simon Large]

Trivial Windows GUI issue. If the preference to "show no errors found" is checked, I get two dialogs after a clean scan.

(Info) No errors found [OK]

followed by

(Error) No errors found, nothing to save. [OK]

If that box is unchecked I still get the second dialog.

[Daniel Marjamäki]

hmm.. I can't reproduce.

That second message box should only be shown if you try to save the results as far as I see. Do you get it without trying to save results?

[Simon Large]

Yep, happens every time I run the analysis. I have a test directory with a single trivial C file in which has no errors.

This is the GUI client. The first dialog has CppCheck in the title bar, the second has CppCheck GUI in the title bar.

[Daniel Marjamäki]

I have removed the message box "No errors found, nothing to save". I assume your problems happen when results are autosaved somewhere.

[Simon Large]

Looking at mainwindow.cpp::1015 it seems like the results are always saved if the build directory is defined, and the GUI always generates a default name for that directory and offers to create it. Is that what you mean by having autosave enabled?

[Daniel Marjamäki]

yes.

[Simon Large]

Ah, OK. I thought that directory had to be defined to get whole program analysis, as the tooltip says.

[Daniel Marjamäki]

Yes I recommend that you define that directory. There are several advantages. Whole program analysis is one of them.