cppcheck does not detect inneficient way of remove last character of a std::string

[Dominique Pelle]

cppcheck does not detect this inefficient way of removing last character of a std::string:

#include <string>

std::string foo(std::string s) {
  // Inefficient way of removing the last character of the string
  // as it creates and moves a temporary string.
  s = s.substr(0, s.size() - 1);
  return s;
}

It could suggest this instead which does not create a temporary string:

#include <string>

std::string foo(std::string s) {
  s.pop_back();
  return s;
}

[Daniel Marjamäki]

Thanks! I have created: https://trac.cppcheck.net/ticket/11166