Double slashes in `(file)` parameter for external application

[Zufu Liu]

See https://github.com/zufuliu/notepad2/issues/378, Cppcheck configured as following.

example arguments passed to Notepad2: -g 4610 D:\\notepad2\\scite\\src\\SciTEBase.cxx (the bug for SciTE is at https://sourceforge.net/p/scintilla/feature-requests/1416/#4569/0a0f).

[Zufu Liu]

bug exists in both Cppcheck 2.5 and 2.6 dev from https://github.com/danmar/cppcheck/actions/runs/1255663738

[Daniel Marjamäki]

Thanks for reporting this problem!

I have created this ticket:
https://trac.cppcheck.net/ticket/10504#ticket

I fear that this ticket could go unfixed for a while. We do not have the resources to fix all problems quickly enough. So if you have time to fix this then that would be highly appreciated.

[Zufu Liu]

If I guessed correct, the double slashes is added by
https://github.com/danmar/cppcheck/blob/main/gui/resultstree.cpp#L778

        //Replace (file) with filename
        QString file = data[FILENAME].toString();
        file = QDir::toNativeSeparators(file);
#ifdef Q_OS_WIN
        file.replace(QString("\\"), QString("\\\\"));
#endif
        qDebug() << "Opening file: " << file;

[Daniel Marjamäki]

the code does not look really robust to me. does it work when there are spaces in the filename?

[Zufu Liu]

Space in file name works, what passed to Notepad2 is:

-g 2537 "D:\\notepad2\\scite\\src\\SciTE Base.cxx"

[Daniel Marjamäki]

I have changed the code with https://github.com/danmar/cppcheck/commit/5767ba794a0ce6a35b4c798da85e6c17ec84e409 so please try it out..

[Zufu Liu]

Thank, tested https://github.com/danmar/cppcheck/actions/runs/1274040688
only one backslash: /g 2537 D:\notepad2\scite\src\SciTEBase.cxx, so it's fixed.