Having duplicates in Trac makes it harder to find the best tickets to solve. In worst case a "low hanging fruit" will go unnoticed and is not solved.
I see many tickets about "double free" , "use after free", "deallocating auto variable".
could somebody lookup and list all these tickets?
please close duplicates if you see them.
imho we should only keep the most primitive tickets in these categories.
I think there are a number of tickets that require symbolic analysis. Could somebody list such tickets? Here is an example where a buffer with dynamic size is used:
If we symbolically analyse "sz" we can see an array index out of bounds.
I would like that these tickets get some common keyword. In my humble opinion, we need to add "ValueNumbering" in Cppcheck, then we will be able to detect a range of such problems. So I suggest we mark these tickets with keyword "valuenumbering". https://en.wikipedia.org/wiki/Value_numbering
Until we have "ValueNumbering" in Cppcheck I am skeptic about having lots of open tickets that require this. We can keep some simple ticket and close all more complex tickets as duplicates.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
All tickets about better handling of "function calls" should probably be marked with the "ctu" keyword. It is better for the long term that we handle function calls using a whole program analysis compatible solution.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I saw that a lot of tickets have been closed as fixed without adding a regression test to your testsuite. We should really try to add them before a ticket is closed.
Last edit: orbitcowboy 2019-01-03
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Having duplicates in Trac makes it harder to find the best tickets to solve. In worst case a "low hanging fruit" will go unnoticed and is not solved.
I see many tickets about "double free" , "use after free", "deallocating auto variable".
could somebody lookup and list all these tickets?
please close duplicates if you see them.
imho we should only keep the most primitive tickets in these categories.
I think there are a number of tickets that require symbolic analysis. Could somebody list such tickets? Here is an example where a buffer with dynamic size is used:
If we symbolically analyse "sz" we can see an array index out of bounds.
I would like that these tickets get some common keyword. In my humble opinion, we need to add "ValueNumbering" in Cppcheck, then we will be able to detect a range of such problems. So I suggest we mark these tickets with keyword "valuenumbering".
https://en.wikipedia.org/wiki/Value_numbering
Until we have "ValueNumbering" in Cppcheck I am skeptic about having lots of open tickets that require this. We can keep some simple ticket and close all more complex tickets as duplicates.
All tickets about better handling of "function calls" should probably be marked with the "ctu" keyword. It is better for the long term that we handle function calls using a whole program analysis compatible solution.
I saw that a lot of tickets have been closed as fixed without adding a regression test to your testsuite. We should really try to add them before a ticket is closed.
Last edit: orbitcowboy 2019-01-03
Closed as fixed? If it is closed as duplicate, adding a unit test would not make sense.