typedef with non-primitive type

[David Lin]

Hi,
I found that cppcheck sometimes not working well with non-primitive typedef.

Version: 1.87

cppcheck --enable=style

With following code snippet, cppcheck can find and emit warning

(style) The function 'foo' overrides a function in a base class but is not marked with a 'override' specifier.

class A {
    public:
        typedef int Type;
        virtual void foo(Type);
};
class B : public A {
    void foo(Type);
};

Howerever,
If Type is defined as std::vector

class A {
    public:
        typedef std::vector<int> Type;
        virtual void foo(Type) ;
};
class B : public A {
    void foo(Type);
};

cppcheck will no longer emit any warnings.

The following are 2 cases that cppcheck will also emit warning.
Case 1:

typedef std::vector<int> Type;
class A {
    public:
        virtual void foo(Type) ;
};
class B : public A {
    void foo(Type);
};

Case2:

class A {
    public:
        typedef std::vector<int> Type;
        virtual void foo(Type) ;
};
class B : public A {
    void foo(std::vector<int>);
};

Looks like that cppcheck is confused with the typedef if both conditions are met:
1. typedef with non-primitive data type
2. typedef in base class scope

Is it a possible bug?

Thanks and regards,
David

[David Lin]

Update:
Lookes like the Type is not correctly deducted from base class's typedef.

But what make me curious is that cppcheck behaves differently by putting typedef out of base class scope.

Shall we have a ticket for this if it is confirmed bug?

I would appreciate if this issue can be fixed.

Thanks,
David

[versat]

IMHO it is a false negative, so i created a ticket: https://trac.cppcheck.net/ticket/9086

[David Lin]

Thank you for confirming this issue.

Thanks,
David