Put XmlReportV2 object on the stack in ResultsView::readErrorsXml()

Static source code analysis tool for C and C++ code

Brought to you by: danielmarjamaki

Put XmlReportV2 object on the stack in ResultsView::readErrorsXml()

Forum: Development

Creator: Markus Elfring

Created: 2018-10-14

Updated: 2018-10-17

Markus Elfring - 2018-10-14

I noticed during a refactoring attempt for Cppcheck's graphical user interface that dynamic memory allocation was used for a XmlReportV2 object within the implementation of the function “ResultsView::readErrorsXml”.
This object was not deleted here if a C++ exception would have been thrown during the processing of data from an input file.

Thus put it on the stack so that this source code place is a bit safer and more efficient.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Daniel Marjamäki - 2018-10-15

yes it's a good catch. I am waiting for the PR.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
- Markus Elfring - 2018-10-17
  
  This source code adjustment was accepted.
  
  If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.