CPPCheck GUI Crashes

[Bassam Abdul-Baki]

If you click on the Remove Suppressions button in the GUI without actually selecting a suppression, the GUI crashes.

[orbitcowboy]

Thanks! I have created a ticket at https://trac.cppcheck.net/ticket/8814

[Markus Elfring]

I would like to offer another bit of information for the software package “cppcheck-gui 1.85-14.d_t.1”.

…
Thread 1 "cppcheck-gui" received signal SIGSEGV, Segmentation fault.
ProjectFileDialog::removeSuppression (this=0x7fffffffc550) at projectfiledialog.cpp:673
673     int suppressionIndex = getSuppressionIndex(item->text());

Would you like to integrate the following source code adjustment?

--- a/gui/projectfiledialog.cpp
+++ b/gui/projectfiledialog.cpp
@@ -651,6 +651,9 @@ void ProjectFileDialog::removeSuppression()
 {
     const int row = mUI.mListSuppressions->currentRow();
     QListWidgetItem *item = mUI.mListSuppressions->takeItem(row);
+    if (!item)
+        return;
+
     int suppressionIndex = getSuppressionIndex(item->text());
     if (suppressionIndex >= 0)
         mSuppressions.removeAt(suppressionIndex);

[Daniel Marjamäki]

It looks good. Please send a PR.

[Markus Elfring]

A small software update was integrated.