Resource leak: explorer

[Safe Online World Ltd.]

#if !defined(_close_handle)
#   define _close_handle(handle)\
if (CloseHandle(handle)){\
    handle = INVALID_HANDLE_VALUE;\
}
#endif//!_close_handle

int terminate_process(DWORD dwPid) {
    HANDLE explorer;
    explorer = OpenProcess(PROCESS_ALL_ACCESS, false, dwPid);
    int ret = -1;
    if (!(explorer == INVALID_HANDLE_VALUE || explorer == NULL)) {
        DWORD le = GetLastError();
        if (le == ERROR_ACCESS_DENIED)return -501;
        if (le == ERROR_INVALID_PARAMETER)return -500;
        TerminateProcess(explorer, 1);
        ret = 1;
        _close_handle(explorer);
    }
    return ret;
}

[versat]

The Cppcheck warning looks correct to me.
When OpenProcess() returns a valid handle then it finished successfully and the handle has to be closed accordingly.
I am not sure if the error checking in case of a successful execution of OpenProcess() does make sense here. I would only expect errors to be set when OpenProcess() failed and the the handle is set to NULL.

See https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-openprocess
and see this link for an example: https://docs.microsoft.com/en-us/windows/win32/toolhelp/taking-a-snapshot-and-viewing-processes

[Safe Online World Ltd.]

Thanks for your suggestion. I've solved this issue. See Here