[lib\valueflow.cpp:899]: (style, inconclusive) Boolean variable 'inconclusive' is used in bitwise operation. Did you mean '||'? [lib\valueflow.cpp:900]: (style, inconclusive) Boolean variable 'inconclusive' is used in bitwise operation. Did you mean '||'? [lib\tokenlist.cpp:1090] -> [Cppcheck\cppcheck-master\lib\tokenlist.h:136]: (style, inconclusive) Technically the member function 'TokenList::createAst' can be const. [lib\importproject.cpp:148]: (performance, inconclusive) Use const reference for 'key' to avoid unnecessary data copying. [lib\importproject.cpp:149]: (performance, inconclusive) Use const reference for 'value' to avoid unnecessary data copying. [cli\main.cpp:0]: (information) The configuration '_MSC_VER' was not checked because its code equals another one.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Boolean variable 'inconclusive' is used in bitwise operation. Did you mean '||'?
It depends on what taste you have. That is a message we have in Cppcheck because some users want to have it. I don't personally like this. So we will not fix this in Cppcheck.
Technically the member function 'TokenList::createAst' can be const.
It says that it can "Technically" be const. That does not cause compiler errors.
That does not mean it "should" be const.
This method modifies the tokens in the tokenlist and therefore it should not be const. You should only be allowed to call this method on non-const TokenList objects.
Use const reference for 'key' to avoid unnecessary data copying.
those are good findings that should be fixed.
(information)
"Information" just means that the configuration might need some tweaks.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
[lib\valueflow.cpp:899]: (style, inconclusive) Boolean variable 'inconclusive' is used in bitwise operation. Did you mean '||'?
[lib\valueflow.cpp:900]: (style, inconclusive) Boolean variable 'inconclusive' is used in bitwise operation. Did you mean '||'?
[lib\tokenlist.cpp:1090] -> [Cppcheck\cppcheck-master\lib\tokenlist.h:136]: (style, inconclusive) Technically the member function 'TokenList::createAst' can be const.
[lib\importproject.cpp:148]: (performance, inconclusive) Use const reference for 'key' to avoid unnecessary data copying.
[lib\importproject.cpp:149]: (performance, inconclusive) Use const reference for 'value' to avoid unnecessary data copying.
[cli\main.cpp:0]: (information) The configuration '_MSC_VER' was not checked because its code equals another one.
thanks!
It depends on what taste you have. That is a message we have in Cppcheck because some users want to have it. I don't personally like this. So we will not fix this in Cppcheck.
It says that it can "Technically" be const. That does not cause compiler errors.
That does not mean it "should" be const.
This method modifies the tokens in the tokenlist and therefore it should not be const. You should only be allowed to call this method on non-const TokenList objects.
those are good findings that should be fixed.
"Information" just means that the configuration might need some tweaks.