2.10.3: build fails with gcc 13

[Tomasz Kłoczko]

I have no account in cppcheck track so I'll report that here.

Looks like latest cppcheck build fails when it is build wih gcc 13.

[  2%] Building CXX object lib/CMakeFiles/cppcheck-core.dir/build/mc_astutils.cpp.o
cd /home/tkloczko/rpmbuild/BUILD/cppcheck-2.10.3/x86_64-redhat-linux-gnu/lib && /usr/bin/g++ -DFILESDIR=\"/usr/share/Cppcheck\" -DHAVE_RULES -DTIXML_USE_STL -I/home/tkloczko/rpmbuild/BUILD/cppcheck-2.10.3/x86_64-redhat-linux-gnu/lib -I/home/tkloczko/rpmbuild/BUILD/cppcheck-2.10.3/lib -I/home/tkloczko/rpmbuild/BUILD/cppcheck-2.10.3/externals -I/home/tkloczko/rpmbuild/BUILD/cppcheck-2.10.3/externals/picojson -I/home/tkloczko/rpmbuild/BUILD/cppcheck-2.10.3/externals/simplecpp -O2 -g -grecord-gcc-switches -pipe -Wall -Werror=format-security -Wp,-U_FORTIFY_SOURCE,-D_FORTIFY_SOURCE=3 -Wp,-D_GLIBCXX_ASSERTIONS -specs=/usr/lib/rpm/redhat/redhat-hardened-cc1 -fstack-protector-strong -specs=/usr/lib/rpm/redhat/redhat-annobin-cc1 -fno-omit-frame-pointer -mno-omit-leaf-frame-pointer -m64 -mtune=generic -fasynchronous-unwind-tables -fstack-clash-protection -fcf-protection -fdata-sections -ffunction-sections -flto=auto -flto-partition=none -DNO_UNIX_SIGNAL_HANDLING -DNDEBUG -std=gnu++11 -pedantic -Wall -Wextra -Wcast-qual -Wfloat-equal -Wmissing-declarations -Wmissing-format-attribute -Wno-long-long -Wpacked -Wredundant-decls -Wundef -Wno-missing-field-initializers -Wno-missing-braces -Wno-sign-compare -Wno-multichar -pipe -Woverloaded-virtual -Wno-maybe-uninitialized -Wsuggest-attribute=noreturn -Wno-shadow -Winvalid-pch -include /home/tkloczko/rpmbuild/BUILD/cppcheck-2.10.3/x86_64-redhat-linux-gnu/lib/CMakeFiles/cppcheck-core.dir/cmake_pch.hxx -MD -MT lib/CMakeFiles/cppcheck-core.dir/build/mc_astutils.cpp.o -MF CMakeFiles/cppcheck-core.dir/build/mc_astutils.cpp.o.d -o CMakeFiles/cppcheck-core.dir/build/mc_astutils.cpp.o -c /home/tkloczko/rpmbuild/BUILD/cppcheck-2.10.3/x86_64-redhat-linux-gnu/lib/build/mc_astutils.cpp
In file included from /usr/include/c++/13/ext/alloc_traits.h:34,
                 from /usr/include/c++/13/bits/basic_string.h:39,
                 from /usr/include/c++/13/string:54,
                 from /home/tkloczko/rpmbuild/BUILD/cppcheck-2.10.3/lib/config.h:84,
                 from /home/tkloczko/rpmbuild/BUILD/cppcheck-2.10.3/lib/precompiled.h:20,
                 from /home/tkloczko/rpmbuild/BUILD/cppcheck-2.10.3/x86_64-redhat-linux-gnu/lib/CMakeFiles/cppcheck-core.dir/cmake_pch.hxx:5,
                 from <command-line>:
/usr/include/c++/13/bits/alloc_traits.h: In instantiation of ‘struct std::__allocator_traits_base::__rebind<TaggedAllocator<ReferenceToken, 3>, ReferenceToken, void>’:
/usr/include/c++/13/bits/alloc_traits.h:94:11:   required by substitution of ‘template<class _Alloc, class _Up> using std::__alloc_rebind = typename std::__allocator_traits_base::__rebind<_Alloc, _Up>::type [with _Alloc = TaggedAllocator<ReferenceToken, 3>; _Up = ReferenceToken]’
/usr/include/c++/13/bits/alloc_traits.h:228:8:   required by substitution of ‘template<class _Alloc> template<class _Tp> using std::allocator_traits< <template-parameter-1-1> >::rebind_alloc = std::__alloc_rebind<_Alloc, _Tp> [with _Tp = ReferenceToken; _Alloc = TaggedAllocator<ReferenceToken, 3>]’
/usr/include/c++/13/ext/alloc_traits.h:126:65:   required from ‘struct __gnu_cxx::__alloc_traits<TaggedAllocator<ReferenceToken, 3>, ReferenceToken>::rebind<ReferenceToken>’
/usr/include/c++/13/bits/stl_vector.h:88:21:   required from ‘struct std::_Vector_base<ReferenceToken, TaggedAllocator<ReferenceToken, 3> >’
/usr/include/c++/13/bits/stl_vector.h:423:11:   required from ‘class std::vector<ReferenceToken, TaggedAllocator<ReferenceToken, 3> >’
/home/tkloczko/rpmbuild/BUILD/cppcheck-2.10.3/lib/smallvector.h:47:7:   required from ‘class SmallVector<ReferenceToken>’
/home/tkloczko/rpmbuild/BUILD/cppcheck-2.10.3/lib/astutils.cpp:1158:58:   required from here
/usr/include/c++/13/bits/alloc_traits.h:70:31: error: static assertion failed: allocator_traits<A>::rebind_alloc<A::value_type> must be A
   70 |                         _Tp>::value,
      |                               ^~~~~
/usr/include/c++/13/bits/alloc_traits.h:70:31: note: ‘std::integral_constant<bool, false>::value’ evaluates to false
/usr/include/c++/13/bits/alloc_traits.h: In instantiation of ‘struct std::__allocator_traits_base::__rebind<TaggedAllocator<const Token*, 9>, const Token*, void>’:
/usr/include/c++/13/bits/alloc_traits.h:94:11:   required by substitution of ‘template<class _Alloc, class _Up> using std::__alloc_rebind = typename std::__allocator_traits_base::__rebind<_Alloc, _Up>::type [with _Alloc = TaggedAllocator<const Token*, 9>; _Up = const Token*]’
/usr/include/c++/13/bits/alloc_traits.h:228:8:   required by substitution of ‘template<class _Alloc> template<class _Tp> using std::allocator_traits< <template-parameter-1-1> >::rebind_alloc = std::__alloc_rebind<_Alloc, _Tp> [with _Tp = const Token*; _Alloc = TaggedAllocator<const Token*, 9>]’
/usr/include/c++/13/ext/alloc_traits.h:126:65:   required from ‘struct __gnu_cxx::__alloc_traits<TaggedAllocator<const Token*, 9>, const Token*>::rebind<const Token*>’
/usr/include/c++/13/bits/stl_vector.h:88:21:   required from ‘struct std::_Vector_base<const Token*, TaggedAllocator<const Token*, 9> >’
/usr/include/c++/13/bits/stl_vector.h:423:11:   required from ‘class std::vector<const Token*, TaggedAllocator<const Token*, 9> >’
/home/tkloczko/rpmbuild/BUILD/cppcheck-2.10.3/lib/smallvector.h:47:7:   required from ‘class SmallVector<const Token*, 9>’
/usr/include/c++/13/bits/stl_stack.h:140:47:   required from ‘class std::stack<const Token*, SmallVector<const Token*, 9> >’
/home/tkloczko/rpmbuild/BUILD/cppcheck-2.10.3/lib/astutils.h:59:46:   required from ‘void visitAstNodes(T*, const TFunc&) [with T = const Token; TFunc = extractForLoopValues(const Token*, int*, bool*, MathLib::bigint*, bool*, MathLib::bigint*, MathLib::bigint*)::<lambda(const Token*)>; <template-parameter-1-3> = void]’
/home/tkloczko/rpmbuild/BUILD/cppcheck-2.10.3/lib/astutils.cpp:887:18:   required from here
/usr/include/c++/13/bits/alloc_traits.h:70:31: error: static assertion failed: allocator_traits<A>::rebind_alloc<A::value_type> must be A
/usr/include/c++/13/bits/alloc_traits.h:70:31: note: ‘std::integral_constant<bool, false>::value’ evaluates to false
make[2]: *** [lib/CMakeFiles/cppcheck-core.dir/build.make:407: lib/CMakeFiles/cppcheck-core.dir/build/mc_astutils.cpp.o] Error 1
make[2]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/cppcheck-2.10.3/x86_64-redhat-linux-gnu'
make[1]: *** [CMakeFiles/Makefile2:1118: lib/CMakeFiles/cppcheck-core.dir/all] Error 2
make[1]: Leaving directory '/home/tkloczko/rpmbuild/BUILD/cppcheck-2.10.3/x86_64-redhat-linux-gnu'
make: *** [Makefile:149: all] Error 2

[CHR]

See https://github.com/danmar/cppcheck/pull/5015