I am not sure if that will be fixed soon. I know what to change but there is some logic which needs to be tested and gives me headaches. I am fixing everything around it though.
Last edit: Oliver Stöneberg 2025-11-17
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Since it seems there will be no fixes for the issues introduced by https://github.com/danmar/cppcheck/pull/7658 it needs to be reverted before release (I will post a PR if nothing happens until the end of the week).
Since it seems there will be no fixes for the issues introduced by https://github.com/danmar/cppcheck/pull/7658 it needs to be reverted before release (I will post a PR if nothing happens until the end of the week).
I guess we can revert it and then the changes can be polished and broken up and resubmitted.
It's still a draft PR. Do I understand correctly that compilation and linking works fine currently? But you want to utilize C++17 better? In that case I don't see this as that critical.
I would like to release Cppcheck 2.19 in couple of weeks.
Please suggest critical bugs that we need to focus on during the coming weeks.
daca crashes looks "acceptable" right now. There are two crashes with HEAD but we had those with 2.18 also.
http://cppcheck1.osuosl.org:8000/crash.html
here is a GUI test report (using a recent release-windows nightly build).
Version V 2.19
PASS 89
FAIL 17
NOT SURE 6
Total Test Cases 112
Last edit: Daniel Marjamäki 2025-11-04
is it ok to release this weekend? I feel there are no specific tickets we must solve.
We should probably fix this first: https://trac.cppcheck.net/ticket/14268 / https://github.com/danmar/simplecpp/issues/589
ok looks like firewave is on it already so we can wait a little..
Last edit: Daniel Marjamäki 2025-11-15
I am not sure if that will be fixed soon. I know what to change but there is some logic which needs to be tested and gives me headaches. I am fixing everything around it though.
Last edit: Oliver Stöneberg 2025-11-17
Since it seems there will be no fixes for the issues introduced by https://github.com/danmar/cppcheck/pull/7658 it needs to be reverted before release (I will post a PR if nothing happens until the end of the week).
We also need to land https://github.com/danmar/cppcheck/pull/7962 - I still want those changes to be cleaner though.
https://github.com/danmar/simplecpp/issues/583 also needs to be fixed (I am waiting for feedback on the initial work).
So does https://github.com/danmar/simplecpp/issues/556 so in turn https://github.com/danmar/simplecpp/pull/475 can finally land.
https://github.com/danmar/simplecpp/issues/570 is also important but I think we can go without that.
I guess we can revert it and then the changes can be polished and broken up and resubmitted.
It's still a draft PR. Do I understand correctly that compilation and linking works fine currently? But you want to utilize C++17 better? In that case I don't see this as that critical.
yeah.. have you been waiting for feedback from me? then I am sorry I missed it, please ping me again in the related PRs..
I agree this is very important I don't see any active PRs though :-(
Is it a regression?