Menu ▾ ▴

#1276 [kubernetes] No default nodegroups in values

open
nobody
do-not-merge (20)
2025-09-04
2025-07-24
Anonymous
No

Originally created by: lllamnyp

Since nodegroups are defined as key-value pairs in the values, there's no easy way to remove the example md0 nodegroup that was provided there for purposes of documentation. Commenting it out from values.yaml keeps the documentation in place, but doesn't force the node group onto users.

Release note:
[kubernetes] Remove potentially undesirable node group from default values of kubernetes chart.

Summary by CodeRabbit

  • Chores
  • Updated the chart version for the Kubernetes application to 0.26.1.

  • Updated version mappings to reflect the new release.

  • Refactor

  • Changed the default node group configuration in Kubernetes values to be empty by default, with previous example settings now commented out. Users must now define node groups explicitly.

Discussion

  • Anonymous

    Anonymous - 2025-07-24

    Originally posted by: coderabbitai[bot]

    Walkthrough

    The changes increment the Kubernetes chart version from 0.26.0 to 0.26.1, update the HEAD pointer and version mapping in versions_map, and modify the default nodeGroups configuration in values.yaml to be empty, moving the previous example to commented-out lines.

    Changes

    File(s) Change Summary
    packages/apps/kubernetes/Chart.yaml Bumped chart version from 0.26.0 to 0.26.1.
    packages/apps/kubernetes/values.yaml Set nodeGroups to an empty object; moved previous example to comments.
    packages/apps/versions_map Updated HEAD and commit hash for 0.26.0; added 0.26.1 as new HEAD version for Kubernetes.

    Sequence Diagram(s)

    sequenceDiagram
    participant User
    participant HelmChart
    participant KubernetesApp

    User->>HelmChart: Deploy/upgrade chart (v0.26.1)
    HelmChart->>KubernetesApp: Apply values.yaml (nodeGroups: {})
    KubernetesApp-->>HelmChart: No default node groups created
    HelmChart-->>User: Deployment complete

    Estimated code review effort

    🎯 2 (Simple) | ⏱️ ~7 minutes

    • [[#569]](https://github.com/cozystack/cozystack/issues/569): Updates version mappings for Kubernetes and other packages, directly related to version mapping changes.
    • [[#568]](https://github.com/cozystack/cozystack/issues/568): Increments Kubernetes chart version and updates versions_map, similar to the current PR but for different versions.

    Suggested labels

    enhancement, size:M, lgtm

    Suggested reviewers

    • kvaps

    Poem

    A hop and a skip, a version hops high,
    Node groups now quiet, configs standing by.
    Chart bumps its number, HEAD finds its way,
    Kubernetes is ready for a brand new day.
    🐇✨

    [!NOTE]


    ⚡️ Unit Test Generation is now available in beta!

    Learn more here, or try it out under "Finishing Touches" below.

    ✨ Finishing Touches
    🧪 Generate unit tests - [ ] Create PR with unit tests - [ ] Post copyable unit tests in a comment - [ ] Commit unit tests in branch `fix/dont-default-nodegroups`

    Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

    ❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
    🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai?utm_source=oss&utm_medium=github&utm_campaign=cozystack/cozystack&utm_content=1276): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit <commit_id>, please review it.` - `Explain this complex logic.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai explain this code block.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and explain its main purpose.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` ### Support Need help? Create a ticket on our [support page](https://www.coderabbit.ai/contact-us/support) for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai generate docstrings` to [generate docstrings](https://docs.coderabbit.ai/finishing-touches/docstrings) for this PR. - `@coderabbitai generate sequence diagram` to generate a sequence diagram of the changes in this PR. - `@coderabbitai generate unit tests` to generate unit tests for this PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://docs.coderabbit.ai) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements. </commit_id>
     

  • Anonymous

    Anonymous - 2025-07-25

    Originally posted by: kvaps

    I'd like to proper testing of this first, to confirm that it will not destroy already existing clusters on update.

     

Log in to post a comment.

MongoDB Logo MongoDB