Re: [maildropl] maildrop 2.2 doesn't install if makedat doesn't build, by default

[Josip R. <jo...@en...>]

On Fri, Nov 06, 2009 at 07:03:11AM -0500, Sam Varshavchik wrote:
> Josip Rodin writes:
>
>> The top-level makefile still expects for makedatprog to get built
>> unconditionally:
>
> Good point.
>
> diff -U3 -r1.77 Makefile.am
> --- Makefile.am	5 Sep 2009 23:12:45 -0000	1.77
> +++ Makefile.am	6 Nov 2009 12:01:24 -0000
> @@ -113,15 +113,20 @@
> 	$(INSTALL_PROGRAM) maildir/maildirmake $(DESTDIR)$(bindir)/maildirmake
> 	$(INSTALL_PROGRAM) rfc2045/reformime $(DESTDIR)$(bindir)/reformime
> 	$(INSTALL_PROGRAM) rfc2045/makemime $(DESTDIR)$(bindir)/makemime
> -	$(INSTALL_PROGRAM) makedat/makedatprog $(DESTDIR)$(bindir)/makedatprog
> -	$(INSTALL_SCRIPT)  makedat/makedat     $(DESTDIR)$(bindir)/makedat
> +	test "@USE_DB@@USE_GDBM@" = "00" && exit 0; \
> +		$(INSTALL_PROGRAM) makedat/makedatprog $(DESTDIR)$(bindir)/makedatprog
> +	test "@USE_DB@@USE_GDBM@" = "00" && exit 0; \
> +		$(INSTALL_SCRIPT)  makedat/makedat     $(DESTDIR)$(bindir)/makedat
> 	. maildrop/uidgid ; test -z "$$gid" && exit 0; test -w /etc || exit 0; cd $(DESTDIR)$(bindir) && chgrp $$gid maildrop lockmail
> 	. maildrop/uidgid ; test -z "$$uid" && exit 0; test -w /etc || exit 0; cd $(DESTDIR)$(bindir) && chown $$uid maildrop lockmail && chmod 755 maildrop lockmail
>
> uninstall-maildrop:
> -	for f in maildrop mailbot maildirmake reformail lockmail makemime reformime makedat makedatprog; do \
> +	for f in maildrop mailbot maildirmake reformail lockmail makemime reformime; do \
> 		rm -f $(DESTDIR)$(bindir)/$$f ; \
> 	done
> +	test "@USE_DB@@USE_GDBM@" = "00" && exit 0; \
> +		rm -f $(DESTDIR)$(bindir)/makedat ; \
> +		rm -f $(DESTDIR)$(bindir)/makedatprog
>
>
> all-recursive: all-make-check
>

That will work, thanks.

Also there's the issue of its manual page and its html version.

I think something like the attached patch should be okay.
 
-- 
     2. That which causes joy or happiness.