#7 CPScanner.findRoots prints stack dumps to stdout for ignored exceptions.

[Scott Cameron]

Seeing stack dumps in the console makes people worry and can confuse debugging for other problems. It would be better if this didn't happen for exceptions that are not truly errors.

There are 2 cases I've seen of this so far in version 1.1.10:

1. In CPScanner.findRoots at line 143 it expects that every JAR must have a META-INF/MANIFEST.MF file and if it doesn't then the openStream call throws a FileNotFoundException.
2. If a Manifest's Class-Path has an unqualified JAR name in it (e.g. "Class-Path: cxf-rt-frontend-jaxrs-3.0.7.jar") there is a MalformedURLException dumped.

There may be others I haven't encountered yet...

[michel]

Absolutely this puts a lot of unwanted noise in the logs. The problem is that they don't rely on any logger library (sl4j, etc.) so they just puke the stack trace at line 160, and that these ones are probably not real errors. The CPScanner should provide a mechanism to deal with the errors, such as to configure a callback, or to override a log method. For instance (untested) :

protected logException(Exception e) {
  e.printStackTrace();
}

and :

 ...
 } catch (IOException e) {
  logException(e);
 }

Thus a programmer who doesn't care and who wants to keep his logs tidy would just have to subclass CPScanner and provide for a cleaner logException method. Additionnaly, the library should define its own specialized exceptions so that one can let go missing manifests but still react to an unexpected problems.

Remark: at 2nd reading I see that all the methods are static (why???) thus the simple override system will not work...