|
From: David K. <da...@em...> - 2012-02-11 12:58:16
|
Code that is unique to a board should go in the platform folder, but code that is useful on several boards can go in the cpu folder made conditional on platform contiki-conf.h defines. Duplicating the same code for each platform is not so bad if it never changes, git compresses it all to one block anyway. But making the same change in several places adds a lot of junk to the log. A platform folder is easy to drop into contiki. Changes elsewhere are best managed through git. I suggest you fork the github contiki:contiki-mirror repo and work from a clone of that. -----Original Message----- From: Konstantin Klubnichkin Sent: Friday, February 10, 2012 8:08 AM To: Contiki developer mailing list Subject: Re: [Contiki-developers] STM32W Hello all! I've solved my "development" issues so now I'm able to compile and flash Contiki into MBxxx series of evaluation boards with stm32w108 chip. At the moment I've found some bugs in the original stm32w code, and I would say I don't agree with the approach "one port for MB851 and another for all other boards". It means that the code for all boards is compiled into final binary, and software onboard (not the developer during compilation) detects on the fly the board type and initializes data structures. For example, in my case, the software tried to initialize the temperature and acceleration sensors that are not present in MB951. As far as I understand STM32W is not the widest used chip, so there are not so many Contiki fellows using it, but anyway, should I fix the bugs and follow the original approach, or make separate ports for the different boards? Also should I share my changes with the community, and what is the right way to do it? Thanks! -- Best regards, Konstantin Klubnichkin |