Re: [Consmgr-tech] mastercont method refactoring?
Status: Alpha
Brought to you by:
cross
|
From: Chris R. <cro...@di...> - 2008-05-23 00:51:47
|
On May 22, 2008, at 11:18, Chris Ross wrote:
> Geoff, you mentioned in IM yesterday that you'd been thinking you
> wanted to refactor some of the code in MasterController. I'm about to
> traipse all over the code I think you were talking about, so I'm
> wondering what you wanted to do? Could you describe it briefly?
Okay. As noted, I think this may be moot now. Take a look at my
changes. There are definately things that could be improved, and I'm
happy for criticism. There's some magic with templating that I know
(or maybe "feel"/"expect") can be done, that I don't know how to do,
but. When templating a method, it can determine the template
parameter without it needing to be given. But, that appears not to
work with classes, so one of the functor classes still needs the
specification. (detach_all, used on line 411 of common/mastercont.cc.
Ack! I realize now that I failed to svn add a new file that has
all the functors in it! Oops! I'll get that in RSN...
- Chris
|