Re: [Consmgr-tech] UDSListener::set_addr()

[Chris R. <cro...@di...>]

On Apr 2, 2008, at 18:03, Geoff Adams wrote:
> Well, whether we said it or not, I tend to agree with that philosophy.
> (I believe we did discuss using accessors to get at things in *other*
> classes--particularly those classes that you compose into yourself as
> a way of having their functionality--which is a little different, but
> the same certainly applies to super/subclasses. So, I'm with you  
> here.)

   Okay, so we should be using a method to do this.  Got it.

> I was in the middle of a lot of changes to these classes, and didn't
> really finish it. This defect is, in particular, probably related to
> the fact that much of this code was split out of SockConn, the Socket
> Connector (which I kinda feel like we should rename that way for
> clarity; just not the file names), which shouldn't actually know
> anything about addresses. So, I was in the middle of moving the
> address-specific stuff into SockConn's subclasses, and SocketListener
> probably inherited some of that change.

   Right.  I see that you were in the middle of a lot of changes,  
which is why I was trying to stay out of them.  There's a lot of work  
yet to do, mostly (it appears) in removing code that's in the wrong  
place, and/or in more than one place.

   And I'd be happy for you to rename the classes. Conn was a unique  
abbreviation when I used it, now that it's not, I see the value in  
renaming the classes...

> Please fix this if you get the chance.

   Okay.  I can fix the "should use the method of superclass to reset  
the superclasses data member" fix.  As for the rest of the changes,  
I'm not really able to do those.  There are a lot of things that look  
odd to me, but since I don't know why the things exist where they do,  
I don't feel that I can change or modify them in code or presence.   
You'll have to finish the rearchitecture of the classes, or at least  
feel you're done, before I'll break into that.  :-)  Too messy in  
there right now.

                    - Chris