Re: [Consmgr-tech] svn practices

[Geoff A. <ga...@av...>]

On 2 Apr 2008, at 8:37 AM, Chris Ross wrote:

>   I know you just made a whole bunch of changes, Geoff, and that it
> was a complicated commit.  But, in the future, when you copy files,
> please "svn copy" the files, so that they carry history.

I always try to do the right thing in this respect. It's a very useful  
feature of Subversion, but only if you use it properly.

> For example,
> all of the listener subclasses which clearly take all of their code
> from the old Connection subclasses have no history.  In the long run
> it won't matter, but it makes it harder for me looking at it now to
> figure out where all of the code came from, because it's all "rev 246
> by gsadams".

I wasn't thinking of these files as having come from anywhere, so I  
created them fresh. Certainly, though, the code came from elsewhere,  
so that would have made sense. Too bad I didn't think of it at the time.

(The process that led to these files was not actually a simple copy,  
although had I known at the time what I knew by the end of the  
process, I would certainly have done them that way. In fact, it's  
still not immediately clear to me that a given new Listener subclass  
comes from a particular old Connection subclass, although there is  
probably a one-to-one correlation, simply because the hierarchy just  
makes sense.)

>   Thanks.  As for listener.h, I see you deleted it and readded it.
> Since it's a new thing of an old name, this I think may've been the
> right (and cool) thing to do.  :-)  Thanks!

Yes. That was the correct operation, IMHO. Subversion calls that  
"replace" when you do it in a single commit. :)

- Geoff