${diskio} reports twice value of actual.

Brought to you by: brenden1, joemyre, pkovacs

This project can now be found here.

#272 ${diskio} reports twice value of actual.

Status: closed-fixed

Owner: nobody

Labels: None

Priority: 5

Updated: 2010-02-03

Created: 2010-01-29

Creator: ichelm

Private: No

I am using conky-1.7.2 with linux-2.6.31-gentoo-r6 on my gentoo box.

Using ${diskio} without argument, it shows twice value of actual value. (See screenshot)

I think that counting total_reads/total_writes (in update_diskio, src/linux.c) is incorrect.
It seems to an entire disk(eg sda) value and each individual partition(eg sda1,sda2,...) value are added to total_reads/total_writes.
But already entire disk value is the sum of each partition.
As a result, I/O values are counted twice.

I am sorry for my lack of coding skill. Regards.

Discussion

ichelm - 2010-01-29

screenshot

screenshot.jpg

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cesare Tirabassi - 2010-01-29

Can you post the output of "cat /proc/diskstats"?
Also consider that diskio will report ALL disk read/writes, so if you have another disk (say sdb) this will get added to sda to get to the total.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

ichelm - 2010-01-29

screenshot 2

screenshot2.jpg

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

ichelm - 2010-01-29

/proc/diskstats

proc_diskstats

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

ichelm - 2010-01-29

I atached /proc/diskstats and new screenshot. There are two HDDs on my box.
Please see screenshot2, ${diskio} reports twice value of I/O.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cesare Tirabassi - 2010-01-29

Looks like the proc diskio interface changed for 2.6.31 and so the awful hack that was used to distinguish between a disk and its partitions doesn't work anymore.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Nobody/Anonymous - 2010-01-30

I just commited a patch for this in the 1.8.0 branch. Before committing to master I would however like you to check it out.
Could you do that?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

ichelm - 2010-01-31

src/linux.c patch

linux.c.patch

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

ichelm - 2010-01-31

patched Conky screenshot

screenshot-mypatch.jpg

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

ichelm - 2010-01-31

Conky with patch from git tree.

screenshot-gitpatch.jpg

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

ichelm - 2010-01-31

Thanks to norsett for your suggestion.
I found a similar case at procps.
See https://bugzilla.redhat.com/show_bug.cgi?id=485243

I simply copied procps's patch to conky-1.7.2/src/linux.c.
And it seems to that works fine. (See screenshot-mypatch)

Also I saw patch on git. But probably it works incorrect for many devices (eg /dev/sr0).
See screenshot-gitpatch, sr0(SATA CD-ROM) I/O has not been counted.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Nobody/Anonymous - 2010-01-31

>Also I saw patch on git. But probably it works incorrect for many devices (eg /dev/sr0).

Well, when we discussed the patch we considered this a feature, not a bug ...

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Cesare Tirabassi - 2010-01-31

Thanks, I uploaded your patch.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

ichelm - 2010-02-01

I applied your new patch (from git) to my conky-1.7.2 ,
Now I can continue happy Conkying with this patch ;)

I think this issue should be Closed/Fixed.
Thank you very much.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

ichelm - 2010-02-03

status: open --> closed-fixed
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.