Re: [Columba-devel] Logging broken

[Mark L. <mli...@ip...>]

Hi Freddy,

> Note, that Ristretto's client-server communication is not using the logging facility, instead it uses System.out! So, this is why you probably don't see it.

Which IIRC was due to my suggestions. OK. However, I had a look and somewhere along the time, I have removed --debug from the menu so what I get might indeed be what I have asked for if not what I want ;-D :-( 

That said, I still think logging is a bit thin so I'm going to turn my attention to it. In doing so, I looked at the meagre logging I have had after several hours of work today and I only had a few kb which starts with this morning as if logging has suddenly become session logging.

That pointed me to columba/ristretto/src/core/org/columba/ristretto/pop3/POP3DownloadThread.java where I fixed a grammatical error but in looking over the code, shouldn't line 38  private static final Logger LOG = Logger.getLogger("org.columba.ristretto.imap.protocol"); be pop3 rather than imap ;-)

I didn't regenerate the ristretto.jar just for a grammar error so maybe you can if I am not getting confused :-)

In fact, I just checked and on my system, non-debug logging has become a session log. The 7.5kb log I had before has just become 1.1kb and all I did was close columba and restart it (and it was not a faulty shutdown AFAICT). I don't recall session logging being the norm before?

HTH

MarkL