Re: [Codenarc-developer] My views on making it easier for people to contribute
Brought to you by:
chrismair
Menu
▾
▴
Re: [Codenarc-developer] My views on making it easier for people to contribute
|
From: Marcin E. <mar...@pr...> - 2012-07-21 15:30:32
|
Chris, I'm glad to hear that you like my ideas. Here are the two feature requests on Sourceforge tracker: https://sourceforge.net/tracker/?func=detail&aid=3546737&group_id=250145&atid=1126575 https://sourceforge.net/tracker/?func=detail&aid=3546740&group_id=250145&atid=1126575 When it comes to the site plugin I'm currently waiting for a response from Rene Gröschke on the status of the plugin (https://github.com/breskeby/GradleSite). After having a quick peek at it I believe it is finished. It's not in central but I could put it there cause I have rights to 'org.gradle.api.plugins' group in Sonatype OSS repo. I can start working on the build migration as soon as we'll put the code into github - I will create a fork of it and submit a pull request when it's ready. I can also help in migrating the source to github, I've migrated some repos in the past from svn to github using git-svn and could pull the source into the new repo given that I will get commit access to CodeNarc's github repository - I won't mind if you revoke it after the migration is done. Cheers, Marcin On 07/21/2012 02:35 PM, Chris Mair wrote: > Marcin, > > Thank you for the feedback (and the CodeNarc contributions). > > I am open to both ideas. Can you please open a feature request for each > suggestion (Git/Github and Gradle): > https://sourceforge.net/tracker/?group_id=250145&atid=1126575. > > Both have been informally suggested before, so it's probably worth getting > them to a place where we can consolidate the discussion of the merits and > trade-offs, and bring Hamlet into the discussion as well. One of the > sticking points with Gradle previously was the lack of a site plugin, since > we currently use Maven to generate the CodeNarc web site from APT files, and > also generate the APT for the Rules Index page. I have not checked on the > status of that lately. > > Thanks. > Chris > > -----Original Message----- > From: Marcin Erdmann [mailto:mar...@pr...] > Sent: Thursday, July 19, 2012 7:34 PM > To: cod...@li... > Subject: [Codenarc-developer] My views on making it easier for people to > contribute > > Hi all, > > In the past I've contributed several rules and fixes to Codenarc. > Recently we've added Codenarc to our project and we found a major bug in > UnnecessarySemicolonRule and wanted to fix it. After checking the project > state I've found out that it's still quite tedious to contribute for two > reasons - svn and maven. > > If you want to contribute to Codenarc you need to send patches in email, > like I did by sending mails to Hamlet in the past. This would be much easier > if the project was on github enabling people to submit pull request... I > don't know if there is a CI build set up for the project but by putting it > on github and hooking it up with buildhive you get CI builds for free, also > for pull requests. Can you please explain what are the reasons for such a > valuable project to be still using svn? > > The other thing is getting the project into your IDE. It would be so much > easier if there was a gradle build available for the project - simply typing > gradle idea would generate the project for you with all the dependencies in > place and no additional settings/tweaks needed. If you're interested I could > try to contribute by migrating current maven build to gradle. I'm already in > talks with Rene Gröschke about his efforts in the past in that area. > > Cheers, > Marcin Erdmann > > ---------------------------------------------------------------------------- > -- > Live Security Virtual Conference > Exclusive live event will cover all the ways today's security and threat > landscape has changed and how IT managers can respond. Discussions will > include endpoint security, mobile security and the latest in malware > threats. http://www.accelacomm.com/jaw/sfrnl04242012/114/50122263/ > _______________________________________________ > Codenarc-developer mailing list > Cod...@li... > https://lists.sourceforge.net/lists/listinfo/codenarc-developer > > |
