Re: [Codenarc-user] GrailsStatelessService - bean properties and dependencies
Brought to you by:
chrismair
From: Roshan D. <ros...@gm...> - 2011-12-16 03:05:12
|
On Fri, Dec 16, 2011 at 12:23 AM, <chr...@we...> wrote: > > > I am just concerned about casting too wide a net (and missing true > violations of statelessness). So, I would be inclined to only ignore > “properties” declared with “def”.**** > > ** ** > > So, public/private/protected fields, or fields with specific types (e.g., > String, int, MyClass) would still cause violations. Is that ok? > Yes, Chris. That sounds ok. In addition, I would suggest, the rule can skip fields with specific types / visibility annotations also if those are annotated as @Inject. I have filed the bug here: https://sourceforge.net/tracker/?func=detail&aid=3460463&group_id=250145&atid=1126573 > ** ** > > >> Spring 3.x also has this annotation called @Inject.**** > > ** ** > > We could consider supporting that. We only check the name of the > annotation (“Inject”), not the type, so in that case there would be no > runtime dependency. > Great! If it can skip on the basis of @Inject without having a runtime dependency. Thanks. -- Roshan http://roshandawrani.wordpress.com/ |